public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rolandd@cisco.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Move InfiniBand .h files
Date: Thu, 04 Aug 2005 11:31:24 -0700	[thread overview]
Message-ID: <52acjxa70j.fsf@cisco.com> (raw)
In-Reply-To: <1123178038.3318.40.camel@laptopd505.fenrus.org> (Arjan van de Ven's message of "Thu, 04 Aug 2005 19:53:58 +0200")

    Arjan> At minimum the headers should be split in separate files
    Arjan> for shared-userspace and kernel (eg no overlap at all), but
    Arjan> I'd vote for keeping the headers in your own dir.

This is already done -- the userspace ABI is defined in ib_user_mad.h,
ib_user_verbs.h, etc.

The problem with keeping subsystem headers under drivers/infiniband is
that it's ugly for, say, fs/nfs/Makefile to have to add
-Idrivers/infiniband/include to its CFLAGS just because it's
implementing NFS/RDMA.

Also, drivers/infiniband/include doesn't get put into the
/lib/modules/<ver>/build directory, so it's a pain for people
developing new drivers (this is a real complaint that came to me from
a vendor developing a driver for a new piece of IB hardware).

Thanks,
  Roland

  parent reply	other threads:[~2005-08-04 18:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-04 17:32 [RFC] Move InfiniBand .h files Roland Dreier
2005-08-04 17:48 ` [openib-general] " Tom Duffy
2005-08-04 17:53 ` Arjan van de Ven
2005-08-04 18:26   ` [openib-general] " Grant Grundler
2005-08-04 19:51     ` Arjan van de Ven
2005-08-04 18:31   ` Roland Dreier [this message]
2005-08-04 18:38     ` Arjan van de Ven
2005-08-04 18:57       ` Roland Dreier
2005-08-04 19:22         ` Sam Ravnborg
2005-08-04 19:54           ` Christopher Friesen
2005-08-04 20:02             ` Sam Ravnborg
2005-08-04 19:51         ` Arjan van de Ven
2005-08-04 18:11 ` [openib-general] " Steve Wise
2005-08-04 18:20 ` Grant Grundler
2005-08-04 18:32   ` Roland Dreier
2005-08-04 21:38 ` James Lentini
2005-08-05  9:22 ` Christoph Hellwig
2005-08-05 16:08   ` Roland Dreier
2005-08-05 21:06     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52acjxa70j.fsf@cisco.com \
    --to=rolandd@cisco.com \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox