public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <roland@topspin.com>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Vicente Feito <vicente.feito@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: workqueue - process context
Date: Sat, 19 Feb 2005 08:19:23 -0800	[thread overview]
Message-ID: <52acq0ttdg.fsf@topspin.com> (raw)
In-Reply-To: <42174DD4.9010506@keyaccess.nl> (Rene Herman's message of "Sat, 19 Feb 2005 15:31:48 +0100")

    Rene> I have no idea about the module refcounting stuff. Is there
    Rene> a chance that create_workqueue() could increase a reference
    Rene> somewhere so that the module wouldn't be allowed to unload
    Rene> untill after a destroy_workqueue()?

There's no point to doing this, since it's adding complexity to try
and avoid a very obvious and easy to find bug.  Other types of
resource leaks are harder to find, but a module not destroying a
workqueue is going to be trivial to spot and fix.

(There are technical issues as well -- if create_workqueue()
increments the module reference count, then you would never be able to
unload the module if the destroy_workqueue() was in the module_exit
function, because you can never even start to unload a module with a
non-zero ref count).

 - R.

  reply	other threads:[~2005-02-19 16:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-19  1:48 workqueue - process context Vicente Feito
2005-02-19  4:57 ` Roland Dreier
2005-02-19  2:02   ` Vicente Feito
2005-02-19  5:03     ` Roland Dreier
2005-02-19 14:31   ` Rene Herman
2005-02-19 16:19     ` Roland Dreier [this message]
2005-02-19 16:52       ` Rene Herman
  -- strict thread matches above, loose matches on Subject: below --
2005-02-19  2:38 Vicente Feito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52acq0ttdg.fsf@topspin.com \
    --to=roland@topspin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rene.herman@keyaccess.nl \
    --cc=vicente.feito@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox