Re: [PATCH v2 1/3] mm: kick writeback flusher instead of inline flush for IOCB_DONTCACHE

Christoph Hellwig
2026-04-09T05:52:10Z

On Thu, Apr 09, 2026 at 07:10:32AM +0530, Ritesh Harjani wrote:
> > +void filemap_dontcache_kick_writeback(struct address_space *mapping)
>
> This api gives a wrong sense that we are kicking writeback to write
> dirty pages which belongs to only this inode's address space mapping.
> But instead we are starting wb for everything on the respective bdi.
>
> So instead why not just export symbol for wakeup_flusher_threads_bdi()
> and use it instead?

I'd rather not expose that to wide with the extra reason arguments
that's not otherwise exposed outside the core writeback code.

Btw, wakeup_flusher_threads_bdi should really be marked static in
fs-writeback.c as well.