From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754783AbcIJUWT (ORCPT ); Sat, 10 Sep 2016 16:22:19 -0400 Received: from mout.web.de ([217.72.192.78]:52194 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbcIJUWR (ORCPT ); Sat, 10 Sep 2016 16:22:17 -0400 Subject: [PATCH 01/13] DRBD-receiver: Use kmalloc_array() in receive_uuids() To: drbd-dev@lists.linbit.com, Lars Ellenberg , Philipp Reisner References: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <52dd5e61-96c1-e309-7a43-20768b05dd24@users.sourceforge.net> Date: Sat, 10 Sep 2016 22:22:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qZo25MiVSfT5UN/ukmKtyuere/CwX5zvLy3ME9mo/Q5/WxUU4gk lws+OKlz9yZa3OIu27BSIOzYdcEZ4lVepj44Ln25/LBJBpeQlw0NQP3WBcr1ZZWj7OrK8Cb XRraMsxcrdQypYWjaZgi2GBI2rxDq7e/1Hgsu6g25H2S4gPb1GCU7LvbhLmcquiNZQDOA1Q Ih5IbYc1Ajv7TCIf6OcDA== X-UI-Out-Filterresults: notjunk:1;V01:K0:zaHxLXu3IWE=:X6m7Qtyz/AodpnpJ0hqAMP ibr1WcQZnPE/iBCwHCoinQ39bNzuZ6jLxO6X2M+8JMmvaA/jHSkEFQL65fL+pGwotNN/TNyKX 6bfl/jd9fp+rdolMC9EAUOEdYr4xjuqGYkTpHdYYuRB56BtibsUmVtgQuXsCV9PMhGUYgCgax BR760MduZSdxooRl7UgohUAvUixDwf8AhmmyAJC+WVZkatjFVUNyv+BYYNIQ32qUKng5REOa1 ern4fo963ILaKLI14C6r7BEKL07W1Ed8UwPr5TVv5Yx1JAaX4/jj9otBBzntTb1iaBos/K9z3 /WH96MyPBhPDgxGiYR0RT9jFH0I1d5Kuyztgk7G2zFM3Wq/6GR9VbMsdY55EhC9B7j8nYP37v oTBFCTLrwUBiy00bkbpRlo7RTAMSd+fapizmiuQjKfs8rC83ypcmI7YLt7KKe0TV/UydB5StO QLQU/Tl8lVU/YjUBwQFCpq7jLnoDsgH993Vscrsj3rNHGFEM4Gq36ON0sOcEoXISX3dFAnnyt 7mJGQgxbd/7qJI6eQ9peYZ/Hwxu4g/tEif5UULDzsK1ApL1oUHyiqgUVWJP+rsbyn8QR9SeHq wXT2JaJjbygvDY5idDcX/KvT6O+50t2Lw+uJJgF53XlEO9d5Jc5SwpthwU/66elLK0pAcUqmR Ef72MJFOjvU70BMQZGT8aAPxzPiMtpapBhJlvJi2ZkG9UMsvT0ZZ5WL5eBtbamKjMEiNDDz78 AWCMoqikCPYsSFDQWMUUrnjqdcTK1AMguu36uCno6YaQPcqB4QM3k1ejqC7qP2xzuEHFHrNRE ovuTTQ6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 19:22:57 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/block/drbd/drbd_receiver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 942384f..3be9fbf 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -4186,7 +4186,7 @@ static int receive_uuids(struct drbd_connection *connection, struct packet_info return config_unknown_volume(connection, pi); device = peer_device->device; - p_uuid = kmalloc(sizeof(u64)*UI_EXTENDED_SIZE, GFP_NOIO); + p_uuid = kmalloc_array(UI_EXTENDED_SIZE, sizeof(*p_uuid), GFP_NOIO); if (!p_uuid) { drbd_err(device, "kmalloc of p_uuid failed\n"); return false; -- 2.10.0