Re: [RFC PATCH] PCI: remove access to pci_[enable|disable]_msi() for drivers - take 2

Luben Tuikov
2005-06-08T15:18:51Z

On 06/07/05 16:21, Greg KH wrote:
> Hm, here's an updated patch that should have fixed the errors I had in
> my previous one where I wasn't disabling MSI for the devices that did
> not want it enabled (note, my patch skips the hotplug and pcie driver
> for now, those would have to be fixed if this patch goes on.)
>
> However, now that I've messed around with the MSI-X logic in the IB
> driver, I'm thinking that this whole thing is just pointless, and I

Agreed.

> should just drop it and we should stick with the current way of enabling
> MSI only if the driver wants it. If you look at the logic in the mthca

Agreed.

> driver you'll see what I mean.
>
> So, anyone else think this is a good idea? Votes for me to just drop it
> and go back to hacking on the driver core instead?

Drop it. Yes.

> Oh, and in looking at the drivers/pci/msi.c file, it could use some
> cleanups to make it smaller and a bit less complex. I've also seen some
> complaints that it is very arch specific (x86 based). But as no other
> arches seem to want to support MSI, I don't really see any need to split
> it up. Any comments about this?

It's up to you.

Luben