From: Yuehaibing <yuehaibing@huawei.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <steffen.klassert@secunet.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <timo.teras@iki.fi>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] xfrm: policy: Fix doulbe free in xfrm_policy_timer
Date: Mon, 23 Mar 2020 15:04:01 +0800 [thread overview]
Message-ID: <52f2d9b2-e66a-f2aa-52fb-d0a3ca748a73@huawei.com> (raw)
In-Reply-To: <20200323062914.GA5811@gondor.apana.org.au>
On 2020/3/23 14:29, Herbert Xu wrote:
> On Mon, Mar 23, 2020 at 09:41:55AM +0800, YueHaibing wrote:
>>
>> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
>> index dbda08ec566e..ae0689174bbf 100644
>> --- a/net/xfrm/xfrm_policy.c
>> +++ b/net/xfrm/xfrm_policy.c
>> @@ -434,6 +434,7 @@ EXPORT_SYMBOL(xfrm_policy_destroy);
>>
>> static void xfrm_policy_kill(struct xfrm_policy *policy)
>> {
>> + write_lock_bh(&policy->lock);
>> policy->walk.dead = 1;
>>
>> atomic_inc(&policy->genid);
>> @@ -445,6 +446,7 @@ static void xfrm_policy_kill(struct xfrm_policy *policy)
>> if (del_timer(&policy->timer))
>> xfrm_pol_put(policy);
>>
>> + write_unlock_bh(&policy->lock);
>
> Why did you expand the critical section? Can't you just undo the
> patch in xfrm_policy_kill?
Indeed, the critical section should not be expanded, thanks!
>
> Cheers,
>
next prev parent reply other threads:[~2020-03-23 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 3:48 [PATCH] xfrm: policy: Fix doulbe free in xfrm_policy_timer YueHaibing
2020-03-23 1:41 ` [PATCH v2] " YueHaibing
2020-03-23 6:29 ` Herbert Xu
2020-03-23 7:04 ` Yuehaibing [this message]
2020-03-23 6:53 ` Timo Teras
2020-03-23 7:21 ` Yuehaibing
2020-03-23 7:56 ` Timo Teras
2020-03-23 7:32 ` [PATCH v3] " YueHaibing
2020-03-23 8:00 ` Timo Teras
2020-03-23 21:44 ` Herbert Xu
2020-03-25 12:53 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f2d9b2-e66a-f2aa-52fb-d0a3ca748a73@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox