From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53E920E717 for ; Wed, 30 Apr 2025 08:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746000431; cv=none; b=nhD4gSvHL2xPWEfEmtRKRpSWtsqWeX/wFY6kf/u/FXZ3TJB858lSF/JtJAesKWsb0ohfIhhnllWhgj82v8l6SCndqq8I0ZimMc5K30cCyK4wqd1Hr9aALFqHSsqzyXDuxIJT1x/SwSWMGMYYCsgVgr6pUZBwLtMWKYHniZhhyrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746000431; c=relaxed/simple; bh=kj8MnihaZ7l+xSJ0ul1JcIed7CGN/pkbiVSMjR9ZINM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X5Iv3aFhJQrJ7fTrIMsEiOei+Gddaz8WjSgTXCadofTv9A5TvLfQseCkQtStmlftTBVctabbItxUHPNsmx+I6agxgSM5MuIopYlrl/1q0cgod5C5tq6Ntap14qOn6ONhBrx9VPOsgVpdrBWeh49sKUNz051v8jRJWuu6u+mQVDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=bYxocgHi; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="bYxocgHi" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-af5085f7861so5224778a12.3 for ; Wed, 30 Apr 2025 01:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1746000429; x=1746605229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=tNCjzmDAsZlbXnWegieKePzLMYEar9QJf6Kl2b6MKpI=; b=bYxocgHi7iwWFGN1FemM/GkE0w2W5/3zgeXfPwFgMkRqgodMfZ8hV3YOH0J4m8Wdkh GaBzX0MYtHyA1zei0aLbss/xx/RtKIEaFFcMwXgha1KXmUVnOcQfHy+AeqG7O9PhbBD/ geOytb2btX+B8gVp/1Mg5kFQsIxYOv7dMxcnE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746000429; x=1746605229; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tNCjzmDAsZlbXnWegieKePzLMYEar9QJf6Kl2b6MKpI=; b=q7HlIhUbY8JmGoRn7n+rdzkgRvDl+n6+5QtcnmVbe2UBqihhh4XnlkoV/RvYqs9FCu X0xSsLXZL3MHW5okeZpGRFfkZtNCGJ1MbaWMVqmXfKYFr5bij5QO50jmX7mJZlDtfJdQ pPiSDfMQRV6nmcVjZPkt+lFqIQh+uIFuIgd4PfP7h212jBZRQRa34qNYQa/vDrJs6YNU eS2IxTrNBrU9CA0mq7jzpjkf68bRIBZzZpf32ptZ+cCUgZBXi47wOw9lJwjjLMEaLb0l DzTF71VmRxhM0oTQl0vJHiu4CfvZr94V2qBo0Ixg06QmqifJcPYmMhEZUkqs5b3GZaMP 49tw== X-Forwarded-Encrypted: i=1; AJvYcCU1vhuBV8so3d+OPn4cMUDMg6IstJdTOir5sHQS3gnMQEH95DE+diPFmQBN8PwDiAfwH3aKECOPJ7/VNl0=@vger.kernel.org X-Gm-Message-State: AOJu0YzbxVFD/0Iwqc7u25GmaZn6FtNp5HCeyrh5pD3E3ieU0YELAALK si8bqG83wc/Sh9sLbXBqJy/V2KZATARTqft1D/3OfUZhh4ScZsyuiezAyRmQVw== X-Gm-Gg: ASbGncs2TkrkfHCHhEGdRq2uv9i/6oJT2rZK1ezmVBiDCFJrcTrl802H9p/4XGv3Tro CA/Dlo5lSJIUEd/GhAl151kL0vKPsVFH8IK+LGTynPNBJuu3ywMOiz8DNjlmUB2ZTvlvHnuXLJk c2VH6VtI8/FHBwiN1pLcVd5RPDMAIxgdyzqcwvE/NPlJDuvHKKjgeZ+OgeRbl88EzVLoW1xX/cj blV9DvuXJZ0sWH4emxbZ+hEqVdXhv2A9qexVnvPLMjAhatlNw4HJBfTmilTmTSkSdRLT2EgXCbq 52FQ9KMsCDMHyt0bIQ8Yhmio0qPTbtwuxW0F9I1iXRJlpzzah9CvHSTk0uNNfSHz84q94dmsEMz mIdc= X-Google-Smtp-Source: AGHT+IE2Wf34OP5aP/4XXzvwXOVRoJ+64fMYoNjsOKD9q02NrP0D4aZ0MPYwkfLQYNofq42CWf2ofw== X-Received: by 2002:a17:90b:2e10:b0:2ee:f80c:6889 with SMTP id 98e67ed59e1d1-30a3446bb6cmr2919932a91.33.1746000428963; Wed, 30 Apr 2025 01:07:08 -0700 (PDT) Received: from [192.168.0.24] (home.mimichou.net. [82.67.5.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30a34a615a1sm947031a91.49.2025.04.30.01.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 01:07:07 -0700 (PDT) Message-ID: <52f4039a-0b7e-4486-ad99-0a65fac3ae70@broadcom.com> Date: Wed, 30 Apr 2025 10:07:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 00/11] net: dsa: b53: accumulated fixes To: Jonas Gorski , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Kurt Kanzenbach Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250429201710.330937-1-jonas.gorski@gmail.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250429201710.330937-1-jonas.gorski@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/29/2025 10:16 PM, Jonas Gorski wrote: > This patchset aims at fixing most issues observed while running the > vlan_unaware_bridge, vlan_aware_bridge and local_termination selftests. > > Most tests succeed with these patches on BCM53115, connected to a > BCM6368. > > It took me a while to figure out that a lot of tests will fail if all > ports have the same MAC address, as the switches drop any frames with > DA == SA. Luckily BCM63XX boards often have enough MACs allocated for > all ports, so I just needed to assign them. > > The still failing tests are: > > FDB learning, both vlan aware aware and unaware: > > This is expected, as b53 currently does not implement changing the > ageing time, and both the bridge code and DSA ignore that, so the > learned entries don't age out as expected. > > ping and ping6 in vlan unaware: > > These fail because of the now fixed learning, the switch trying to > forward packet ingressing on one of the standalone ports to the learned > port of the mac address when the packets ingressed on the bridged port. Sorry not quite getting that part, can you expand a bit more? > > The port VLAN masks only prevent forwarding to other ports, but the ARL > lookup will still happen, and the packet gets dropped because the port > isn't allowed to forward there. OK. > > I have a fix/workaround for that, but as it is a bit more controversial > and makes use of an unrelated feature, I decided to hold off from that > and post it later. Can you expand on the fix/workaround you have? > > This wasn't noticed so far, because learning was never working in VLAN > unaware mode, so the traffic was always broadcast (which sidesteps the > issue). > > Finally some of the multicast tests from local_termination fail, where > the reception worked except it shouldn't. This doesn't seem to me as a > super serious issue, so I didn't attempt to debug/fix these yet. > > I'm not super confident I didn't break sf2 along the way, but I did > compile test and tried to find ways it cause issues (I failed to find > any). I hope Florian will tell me. I am currently out of the office but intend to test your patch series at some point in the next few days. Let's gather some review feedback in the meantime, thanks for submitting those fixes! -- Florian