From: Roland Dreier <rolandd@cisco.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: ecashin@coraid.com, linux-kernel@vger.kernel.org, jmacbaine@gmail.com
Subject: Re: aoe fails on sparc64
Date: Mon, 19 Sep 2005 11:29:16 -0700 [thread overview]
Message-ID: <52irwwgbcz.fsf@cisco.com> (raw)
In-Reply-To: <20050919.112159.55767801.davem@davemloft.net> (David S. Miller's message of "Mon, 19 Sep 2005 11:21:59 -0700 (PDT)")
David> Although it's very much discouraged to dereference
David> unaligned pointers, especially in performance critical code
David> (which this AOE case is not, thankfully), because
David> performance will be really bad as the trap handler has to
David> fix up the access on RISC platforms.
Also, ia64 has a tendency to print an ugly message in the kernel log
for unaligned accesses. Has anyone tried AoE on ia64?
It might be better to change the AoE code to use get_unaligned(), just
to document what's going on. Although clearly the sparc64 patch is
correct as well -- we should never silently return the wrong data.
- R.
next prev parent reply other threads:[~2005-09-19 18:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-31 13:30 aoe fails on sparc64 Jim MacBaine
2005-08-31 15:50 ` Ed L Cashin
2005-09-01 6:24 ` David S. Miller
2005-09-01 19:13 ` Ed L Cashin
2005-09-01 19:45 ` David S. Miller
2005-09-03 16:06 ` Jim MacBaine
2005-09-06 20:31 ` Ed L Cashin
2005-09-09 14:06 ` Ed L Cashin
2005-09-16 13:36 ` Ed L Cashin
2005-09-16 20:34 ` David S. Miller
2005-09-16 23:35 ` David S. Miller
2005-09-17 10:10 ` Jim MacBaine
2005-09-18 6:12 ` David S. Miller
2005-09-19 14:24 ` Ed L Cashin
2005-09-19 18:21 ` David S. Miller
2005-09-19 18:29 ` Roland Dreier [this message]
2005-09-19 18:38 ` Ed L Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52irwwgbcz.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=davem@davemloft.net \
--cc=ecashin@coraid.com \
--cc=jmacbaine@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox