* [PATCH][10/10] verify_area cleanup : deprecate
@ 2005-03-04 2:49 Jesper Juhl
2005-03-04 4:41 ` Roland Dreier
0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2005-03-04 2:49 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton
The previous 9 patches should take care of converting all callers of
verify_area into access_ok, so now it's time to deprecate verify_area all
over so noone gets tempted to use it in new code - this patch does that.
Eventually when this has been deprecated for a while I'll send patches to
completely remove the function (thoughts on how long it should be
deprecated first are welcome).
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
diff -urp linux-2.6.11-orig/include/asm-alpha/uaccess.h linux-2.6.11/include/asm-alpha/uaccess.h
--- linux-2.6.11-orig/include/asm-alpha/uaccess.h 2005-03-02 08:38:17.000000000 +0100
+++ linux-2.6.11/include/asm-alpha/uaccess.h 2005-03-03 23:58:56.000000000 +0100
@@ -48,7 +48,8 @@
__access_ok(((unsigned long)(addr)),(size),get_fs()); \
})
-extern inline int verify_area(int type, const void __user * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+extern inline int __deprecated verify_area(int type, const void __user * addr, unsigned long size)
{
return access_ok(type,addr,size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-arm/uaccess.h linux-2.6.11/include/asm-arm/uaccess.h
--- linux-2.6.11-orig/include/asm-arm/uaccess.h 2005-03-02 08:38:12.000000000 +0100
+++ linux-2.6.11/include/asm-arm/uaccess.h 2005-03-03 23:58:56.000000000 +0100
@@ -77,7 +77,8 @@ static inline void set_fs (mm_segment_t
#define access_ok(type,addr,size) (__range_ok(addr,size) == 0)
-static inline int verify_area(int type, const void __user *addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated verify_area(int type, const void __user *addr, unsigned long size)
{
return access_ok(type, addr, size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-arm26/uaccess.h linux-2.6.11/include/asm-arm26/uaccess.h
--- linux-2.6.11-orig/include/asm-arm26/uaccess.h 2005-03-02 08:37:48.000000000 +0100
+++ linux-2.6.11/include/asm-arm26/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -40,7 +40,8 @@ extern int fixup_exception(struct pt_reg
#define access_ok(type,addr,size) (__range_ok(addr,size) == 0)
-static inline int verify_area(int type, const void * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated verify_area(int type, const void * addr, unsigned long size)
{
return access_ok(type, addr, size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-cris/uaccess.h linux-2.6.11/include/asm-cris/uaccess.h
--- linux-2.6.11-orig/include/asm-cris/uaccess.h 2005-03-02 08:37:48.000000000 +0100
+++ linux-2.6.11/include/asm-cris/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -91,7 +91,8 @@
#define __access_ok(addr,size) (__kernel_ok || __user_ok((addr),(size)))
#define access_ok(type,addr,size) __access_ok((unsigned long)(addr),(size))
-extern inline int verify_area(int type, const void __user * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+extern inline int __deprecated verify_area(int type, const void __user * addr, unsigned long size)
{
return access_ok(type,addr,size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-frv/uaccess.h linux-2.6.11/include/asm-frv/uaccess.h
--- linux-2.6.11-orig/include/asm-frv/uaccess.h 2005-03-02 08:38:33.000000000 +0100
+++ linux-2.6.11/include/asm-frv/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -67,7 +67,8 @@ static inline int ___range_ok(unsigned l
#define access_ok(type,addr,size) (__range_ok((addr), (size)) == 0)
#define __access_ok(addr,size) (__range_ok((addr), (size)) == 0)
-static inline int verify_area(int type, const void * addr, unsigned long size)
+/* this function will go away soon - use access_ok() / __range_ok() instead */
+static inline int __deprecated verify_area(int type, const void * addr, unsigned long size)
{
return __range_ok(addr, size);
}
diff -urp linux-2.6.11-orig/include/asm-h8300/uaccess.h linux-2.6.11/include/asm-h8300/uaccess.h
--- linux-2.6.11-orig/include/asm-h8300/uaccess.h 2005-03-02 08:37:54.000000000 +0100
+++ linux-2.6.11/include/asm-h8300/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -24,7 +24,8 @@ static inline int __access_ok(unsigned l
return(RANGE_CHECK_OK(addr, size, 0L, (unsigned long)&_ramend));
}
-static inline int verify_area(int type, const void *addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated verify_area(int type, const void *addr, unsigned long size)
{
return access_ok(type,addr,size)?0:-EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-i386/uaccess.h linux-2.6.11/include/asm-i386/uaccess.h
--- linux-2.6.11-orig/include/asm-i386/uaccess.h 2005-03-02 08:37:49.000000000 +0100
+++ linux-2.6.11/include/asm-i386/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -84,7 +84,8 @@ extern struct movsl_mask {
#define access_ok(type,addr,size) (likely(__range_ok(addr,size) == 0))
/**
- * verify_area: - Obsolete, use access_ok()
+ * verify_area: - Obsolete/deprecated and will go away soon,
+ * use access_ok() instead.
* @type: Type of access: %VERIFY_READ or %VERIFY_WRITE
* @addr: User space pointer to start of block to check
* @size: Size of block to check
@@ -100,7 +101,7 @@ extern struct movsl_mask {
*
* See access_ok() for more details.
*/
-static inline int verify_area(int type, const void __user * addr, unsigned long size)
+static inline int __deprecated verify_area(int type, const void __user * addr, unsigned long size)
{
return access_ok(type,addr,size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-ia64/uaccess.h linux-2.6.11/include/asm-ia64/uaccess.h
--- linux-2.6.11-orig/include/asm-ia64/uaccess.h 2005-03-02 08:37:53.000000000 +0100
+++ linux-2.6.11/include/asm-ia64/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -69,7 +69,8 @@
})
#define access_ok(type, addr, size) __access_ok((addr), (size), get_fs())
-static inline int
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated
verify_area (int type, const void __user *addr, unsigned long size)
{
return access_ok(type, addr, size) ? 0 : -EFAULT;
diff -urp linux-2.6.11-orig/include/asm-m32r/uaccess.h linux-2.6.11/include/asm-m32r/uaccess.h
--- linux-2.6.11-orig/include/asm-m32r/uaccess.h 2005-03-02 08:38:25.000000000 +0100
+++ linux-2.6.11/include/asm-m32r/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -121,7 +121,8 @@ static inline int access_ok(int type, co
#endif /* CONFIG_MMU */
/**
- * verify_area: - Obsolete, use access_ok()
+ * verify_area: - Obsolete/deprecated and will go away soon,
+ * use access_ok() instead.
* @type: Type of access: %VERIFY_READ or %VERIFY_WRITE
* @addr: User space pointer to start of block to check
* @size: Size of block to check
@@ -137,7 +138,7 @@ static inline int access_ok(int type, co
*
* See access_ok() for more details.
*/
-static inline int verify_area(int type, const void __user *addr,
+static inline int __deprecated verify_area(int type, const void __user *addr,
unsigned long size)
{
return access_ok(type, addr, size) ? 0 : -EFAULT;
diff -urp linux-2.6.11-orig/include/asm-m68k/uaccess.h linux-2.6.11/include/asm-m68k/uaccess.h
--- linux-2.6.11-orig/include/asm-m68k/uaccess.h 2005-03-02 08:37:49.000000000 +0100
+++ linux-2.6.11/include/asm-m68k/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -14,9 +14,10 @@
/* We let the MMU do all checking */
#define access_ok(type,addr,size) 1
-static inline int verify_area(int type, const void *addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated verify_area(int type, const void *addr, unsigned long size)
{
- return access_ok(type,addr,size)?0:-EFAULT;
+ return access_ok(type,addr,size) ? 0 : -EFAULT;
}
/*
diff -urp linux-2.6.11-orig/include/asm-m68knommu/uaccess.h linux-2.6.11/include/asm-m68knommu/uaccess.h
--- linux-2.6.11-orig/include/asm-m68knommu/uaccess.h 2005-03-02 08:38:13.000000000 +0100
+++ linux-2.6.11/include/asm-m68knommu/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -23,7 +23,8 @@ static inline int _access_ok(unsigned lo
(is_in_rom(addr) && is_in_rom(addr+size)));
}
-extern inline int verify_area(int type, const void * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+extern inline int __deprecated verify_area(int type, const void * addr, unsigned long size)
{
return access_ok(type,addr,size)?0:-EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-mips/uaccess.h linux-2.6.11/include/asm-mips/uaccess.h
--- linux-2.6.11-orig/include/asm-mips/uaccess.h 2005-03-02 08:37:45.000000000 +0100
+++ linux-2.6.11/include/asm-mips/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -112,7 +112,8 @@
likely(__access_ok((unsigned long)(addr), (size),__access_mask))
/*
- * verify_area: - Obsolete, use access_ok()
+ * verify_area: - Obsolete/deprecated and will go away soon,
+ * use access_ok() instead.
* @type: Type of access: %VERIFY_READ or %VERIFY_WRITE
* @addr: User space pointer to start of block to check
* @size: Size of block to check
@@ -128,7 +129,7 @@
*
* See access_ok() for more details.
*/
-static inline int verify_area(int type, const void * addr, unsigned long size)
+static inline int __deprecated verify_area(int type, const void * addr, unsigned long size)
{
return access_ok(type, addr, size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-parisc/uaccess.h linux-2.6.11/include/asm-parisc/uaccess.h
--- linux-2.6.11-orig/include/asm-parisc/uaccess.h 2005-03-02 08:37:50.000000000 +0100
+++ linux-2.6.11/include/asm-parisc/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -35,7 +35,9 @@ extern int __put_kernel_bad(void);
extern int __put_user_bad(void);
#define access_ok(type,addr,size) (1)
-#define verify_area(type,addr,size) (0)
+#define verify_area(type,addr,size) (0) /* FIXME: all users should go away soon,
+ * and use access_ok instead, then this
+ * should be removed. */
#define put_user __put_user
#define get_user __get_user
diff -urp linux-2.6.11-orig/include/asm-ppc/uaccess.h linux-2.6.11/include/asm-ppc/uaccess.h
--- linux-2.6.11-orig/include/asm-ppc/uaccess.h 2005-03-02 08:37:31.000000000 +0100
+++ linux-2.6.11/include/asm-ppc/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -37,7 +37,8 @@
#define access_ok(type, addr, size) \
(__chk_user_ptr(addr),__access_ok((unsigned long)(addr),(size)))
-extern inline int verify_area(int type, const void __user * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+extern inline int __deprecated verify_area(int type, const void __user * addr, unsigned long size)
{
return access_ok(type, addr, size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-ppc64/uaccess.h linux-2.6.11/include/asm-ppc64/uaccess.h
--- linux-2.6.11-orig/include/asm-ppc64/uaccess.h 2005-03-02 08:38:09.000000000 +0100
+++ linux-2.6.11/include/asm-ppc64/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -56,7 +56,8 @@
#define access_ok(type,addr,size) \
__access_ok(((__force unsigned long)(addr)),(size),get_fs())
-static inline int verify_area(int type, const void __user *addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated verify_area(int type, const void __user *addr, unsigned long size)
{
return access_ok(type,addr,size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-s390/uaccess.h linux-2.6.11/include/asm-s390/uaccess.h
--- linux-2.6.11-orig/include/asm-s390/uaccess.h 2005-03-02 08:37:49.000000000 +0100
+++ linux-2.6.11/include/asm-s390/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -65,7 +65,8 @@
#define access_ok(type,addr,size) __access_ok(addr,size)
-extern inline int verify_area(int type, const void __user *addr,
+/* this function will go away soon - use access_ok() instead */
+extern inline int __deprecated verify_area(int type, const void __user *addr,
unsigned long size)
{
return access_ok(type, addr, size) ? 0 : -EFAULT;
diff -urp linux-2.6.11-orig/include/asm-sh/uaccess.h linux-2.6.11/include/asm-sh/uaccess.h
--- linux-2.6.11-orig/include/asm-sh/uaccess.h 2005-03-02 08:38:08.000000000 +0100
+++ linux-2.6.11/include/asm-sh/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -146,7 +146,8 @@ static inline int access_ok(int type, co
return __access_ok(addr, size);
}
-static inline int verify_area(int type, const void __user * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated verify_area(int type, const void __user * addr, unsigned long size)
{
return access_ok(type,addr,size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-sh64/uaccess.h linux-2.6.11/include/asm-sh64/uaccess.h
--- linux-2.6.11-orig/include/asm-sh64/uaccess.h 2005-03-02 08:37:52.000000000 +0100
+++ linux-2.6.11/include/asm-sh64/uaccess.h 2005-03-03 23:58:57.000000000 +0100
@@ -60,7 +60,8 @@
#define access_ok(type,addr,size) (__range_ok(addr,size) == 0)
#define __access_ok(addr,size) (__range_ok(addr,size) == 0)
-extern inline int verify_area(int type, const void __user * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+extern inline int __deprecated verify_area(int type, const void __user * addr, unsigned long size)
{
return access_ok(type,addr,size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-sparc/uaccess.h linux-2.6.11/include/asm-sparc/uaccess.h
--- linux-2.6.11-orig/include/asm-sparc/uaccess.h 2005-03-02 08:38:25.000000000 +0100
+++ linux-2.6.11/include/asm-sparc/uaccess.h 2005-03-03 23:58:58.000000000 +0100
@@ -46,9 +46,10 @@
#define __access_ok(addr,size) (__user_ok((addr) & get_fs().seg,(size)))
#define access_ok(type,addr,size) __access_ok((unsigned long)(addr),(size))
-static inline int verify_area(int type, const void __user * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated verify_area(int type, const void __user * addr, unsigned long size)
{
- return access_ok(type,addr,size)?0:-EFAULT;
+ return access_ok(type,addr,size) ? 0 : -EFAULT;
}
/*
diff -urp linux-2.6.11-orig/include/asm-sparc64/uaccess.h linux-2.6.11/include/asm-sparc64/uaccess.h
--- linux-2.6.11-orig/include/asm-sparc64/uaccess.h 2005-03-02 08:38:37.000000000 +0100
+++ linux-2.6.11/include/asm-sparc64/uaccess.h 2005-03-03 23:58:58.000000000 +0100
@@ -54,7 +54,8 @@ do { \
#define __access_ok(addr,size) ((void)(addr), (void)(size), 1)
#define access_ok(type,addr,size) ((void)(type), (void)(addr), (void)(size), 1)
-static inline int verify_area(int type, const void __user * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated verify_area(int type, const void __user * addr, unsigned long size)
{
return 0;
}
diff -urp linux-2.6.11-orig/include/asm-v850/uaccess.h linux-2.6.11/include/asm-v850/uaccess.h
--- linux-2.6.11-orig/include/asm-v850/uaccess.h 2005-03-02 08:38:18.000000000 +0100
+++ linux-2.6.11/include/asm-v850/uaccess.h 2005-03-03 23:58:58.000000000 +0100
@@ -27,7 +27,8 @@ extern inline int access_ok (int type, c
return val >= (0x80 + NUM_CPU_IRQS*16) && val < 0xFFFFF000;
}
-extern inline int verify_area (int type, const void *addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+extern inline int __deprecated verify_area (int type, const void *addr, unsigned long size)
{
return access_ok (type, addr, size) ? 0 : -EFAULT;
}
diff -urp linux-2.6.11-orig/include/asm-x86_64/uaccess.h linux-2.6.11/include/asm-x86_64/uaccess.h
--- linux-2.6.11-orig/include/asm-x86_64/uaccess.h 2005-03-02 08:38:37.000000000 +0100
+++ linux-2.6.11/include/asm-x86_64/uaccess.h 2005-03-03 23:58:58.000000000 +0100
@@ -49,7 +49,8 @@
#define access_ok(type, addr, size) (__range_not_ok(addr,size) == 0)
-extern inline int verify_area(int type, const void __user * addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+extern inline int __deprecated verify_area(int type, const void __user * addr, unsigned long size)
{
return access_ok(type,addr,size) ? 0 : -EFAULT;
}
--- linux-2.6.11-orig/arch/um/include/um_uaccess.h 2005-03-02 08:38:13.000000000 +0100
+++ linux-2.6.11/arch/um/include/um_uaccess.h 2005-03-04 00:41:13.000000000 +0100
@@ -20,7 +20,8 @@
#define access_ok(type, addr, size) \
CHOOSE_MODE_PROC(access_ok_tt, access_ok_skas, type, addr, size)
-static inline int verify_area(int type, const void __user *addr, unsigned long size)
+/* this function will go away soon - use access_ok() instead */
+static inline int __deprecated verify_area(int type, const void __user *addr, unsigned long size)
{
return (CHOOSE_MODE_PROC(verify_area_tt, verify_area_skas, type, addr,
size));
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][10/10] verify_area cleanup : deprecate
2005-03-04 2:49 [PATCH][10/10] verify_area cleanup : deprecate Jesper Juhl
@ 2005-03-04 4:41 ` Roland Dreier
2005-03-04 10:23 ` Jesper Juhl
0 siblings, 1 reply; 3+ messages in thread
From: Roland Dreier @ 2005-03-04 4:41 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-kernel, Andrew Morton
Jesper> Eventually when this has been deprecated for a while I'll
Jesper> send patches to completely remove the function (thoughts
Jesper> on how long it should be deprecated first are welcome).
I don't have an opinion on how long to wait before removing the
function, but this patch should probably add an entry to
Documentation/feature-removal.txt.
- R.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][10/10] verify_area cleanup : deprecate
2005-03-04 4:41 ` Roland Dreier
@ 2005-03-04 10:23 ` Jesper Juhl
0 siblings, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2005-03-04 10:23 UTC (permalink / raw)
To: Roland Dreier; +Cc: linux-kernel, Andrew Morton
On Thu, 3 Mar 2005, Roland Dreier wrote:
> Jesper> Eventually when this has been deprecated for a while I'll
> Jesper> send patches to completely remove the function (thoughts
> Jesper> on how long it should be deprecated first are welcome).
>
> I don't have an opinion on how long to wait before removing the
> function, but this patch should probably add an entry to
> Documentation/feature-removal.txt.
>
Something like this should do I assume. I'll add that to the deprecation
patch in the future.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
--- linux-2.6.11-orig/Documentation/feature-removal-schedule.txt 2005-03-02 08:38:13.000000000 +0100
+++ linux-2.6.11/Documentation/feature-removal-schedule.txt 2005-03-04 11:19:48.000000000 +0100
@@ -15,3 +15,9 @@
against the LSB, and can be replaced by using udev.
Who: Greg Kroah-Hartman <greg@kroah.com>
+What: verify_area
+When: May 2005
+Files: include/asm-*/uaccess.h
+Why: Obsolete, replaced by (and simply a wrapper for) access_ok.
+Who: Jesper Juhl <juhl-lkml@dif.dk>
+
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-04 10:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-04 2:49 [PATCH][10/10] verify_area cleanup : deprecate Jesper Juhl
2005-03-04 4:41 ` Roland Dreier
2005-03-04 10:23 ` Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox