From: Roland Dreier <roland@topspin.com>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Grover <andy.grover@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>, Greg KH <gregkh@suse.de>,
"David S. Miller" <davem@davemloft.net>,
tom.l.nguyen@intel.com, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] PCI: remove access to pci_[enable|disable]_msi() for drivers - take 2
Date: Wed, 08 Jun 2005 08:57:22 -0700 [thread overview]
Message-ID: <52k6l4et99.fsf@topspin.com> (raw)
In-Reply-To: <20050608133503.GT23831@wotan.suse.de> (Andi Kleen's message of "Wed, 8 Jun 2005 15:35:03 +0200")
Andi> I think we should have the right (default MSI) API by
Andi> default. If we wait 5 years we end up with lots of mess in
Andi> the drivers.
I agree that we should get the API correct as soon as we can. However
I would argue that one property of the correct API would be that
changing the default from MSI turned off to MSI turned on should not
affect the API.
I like Jeff's suggestion of rolling more common code into
pci_enable_device(). However I'm not sure if this fixes the MSI mess
completely -- there may be some devices where the driver wants to test
interrupt generation and disable MSI if it fails. However this may be
enough of a special case that we can just add a flag to those
particular drivers so that users can manually control the use of MSI.
- R.
next prev parent reply other threads:[~2005-06-08 16:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050608060242.GA8035@mellanox.co.il>
2005-06-07 0:20 ` [RFC PATCH] PCI: remove access to pci_[enable|disable]_msi() for drivers Greg KH
2005-06-07 1:09 ` Andrew Vasquez
2005-06-07 5:15 ` Greg KH
2005-06-07 7:31 ` Arjan van de Ven
2005-06-07 16:08 ` Grant Grundler
2005-06-07 16:10 ` Greg KH
2005-06-07 20:41 ` Arjan van de Ven
2005-06-07 22:08 ` Greg KH
2005-06-07 22:43 ` Roland Dreier
2005-06-08 4:42 ` Grant Grundler
2005-06-08 13:34 ` Andi Kleen
2005-06-08 13:37 ` Andi Kleen
2005-06-08 17:04 ` Grant Grundler
2005-06-09 4:54 ` Stefan Smietanowski
2005-06-09 5:26 ` Greg KH
2005-06-07 15:53 ` Grant Grundler
2005-06-07 16:12 ` Greg KH
2005-06-07 20:21 ` [RFC PATCH] PCI: remove access to pci_[enable|disable]_msi() for drivers - take 2 Greg KH
2005-06-07 22:17 ` Jeff Garzik
2005-06-08 5:55 ` Andrew Grover
2005-06-08 6:14 ` Jeff Garzik
2005-06-08 6:18 ` Jeff Garzik
2005-06-08 13:35 ` Andi Kleen
2005-06-08 15:57 ` Roland Dreier [this message]
2005-06-08 5:02 ` Grant Grundler
2005-06-08 13:32 ` Andi Kleen
2005-06-08 15:52 ` Roland Dreier
2005-06-09 14:03 ` Andi Kleen
2005-06-08 16:09 ` Ashok Raj
2005-06-09 1:37 ` Zwane Mwaikambo
2005-06-09 14:11 ` Andi Kleen
2005-06-09 15:58 ` Ashok Raj
2005-06-08 15:47 ` Roland Dreier
2005-06-08 13:31 ` Andi Kleen
2005-06-08 17:56 ` Greg KH
2005-06-08 15:18 ` Luben Tuikov
2005-06-08 18:47 ` Michael S. Tsirkin
2005-06-07 22:40 Nguyen, Tom L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52k6l4et99.fsf@topspin.com \
--to=roland@topspin.com \
--cc=ak@suse.de \
--cc=andy.grover@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox