public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <roland@topspin.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: inappropriate use of in_atomic()
Date: Thu, 10 Mar 2005 20:53:45 -0800	[thread overview]
Message-ID: <52k6oe9412.fsf@topspin.com> (raw)
In-Reply-To: <20050310204006.48286d17.akpm@osdl.org> (Andrew Morton's message of "Thu, 10 Mar 2005 20:40:06 -0800")

    > Consequently the use of in_atomic() in the below files is probably
    > deadlocky if CONFIG_PREEMPT=n:
    ...
    > 	drivers/infiniband/core/mad.c

Thanks for pointing this out.  I'll get you a patch in the next day or
two.  As you can probably tell, the code is just trying to decide
whether to use GFP_ATOMIC or GFP_KERNEL to allocate a couple of
things, depending on what context we're being called from.  So at
worst we can just change to GFP_ATOMIC unconditionally.

I'll check into whether we can do something cleverer, but just going
the GFP_ATOMIC route won't be horrible.

Thanks,
  Roland

  reply	other threads:[~2005-03-11  4:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-11  4:40 inappropriate use of in_atomic() Andrew Morton
2005-03-11  4:53 ` Roland Dreier [this message]
2005-03-11 12:38   ` Arjan van de Ven
2005-03-11  6:25 ` Stephen Rothwell
2005-03-11  9:11 ` [ACPI] " Jan Kasprzak
2005-03-11  9:46   ` Andrew Morton
2005-03-11 12:26     ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2005-03-12  0:13       ` Andrew Morton
2005-03-12  0:22         ` Benjamin Herrenschmidt
2005-05-31  0:20 ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52k6oe9412.fsf@topspin.com \
    --to=roland@topspin.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox