From: Roland Dreier <rolandd@cisco.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH 11/16] IB uverbs: add mthca mmap support
Date: Tue, 05 Jul 2005 12:20:58 -0700 [thread overview]
Message-ID: <52mzp1oy91.fsf@topspin.com> (raw)
In-Reply-To: <20050628170553.00a14a29.akpm@osdl.org> (Andrew Morton's message of "Tue, 28 Jun 2005 17:05:53 -0700")
Andrew> What's the thinking behind the VM_DONTCOPY there?
As I said before, I don't think the thinking behind VM_DONTCOPY was
correct thinking. Let's take it out.
I've now answered all your questions on this patchset (or at least
written something in response to all your questions ;). What's your
feeling on merging? If more info is required, just let me know. I'll
also be at the kernel summit in a couple of weeks if you want to go
over it in person.
- R.
There's no need to set VM_DONTCOPY when mmap()ing the hardware
doorbell page into userspace.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
--- linux-export.orig/drivers/infiniband/hw/mthca/mthca_provider.c 2005-06-28 15:20:28.000000000 -0700
+++ linux-export/drivers/infiniband/hw/mthca/mthca_provider.c 2005-07-05 12:14:20.838664330 -0700
@@ -347,7 +347,6 @@
return -EINVAL;
vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
- vma->vm_flags |= VM_DONTCOPY;
if (remap_pfn_range(vma, vma->vm_start,
to_mucontext(context)->uar.pfn,
next prev parent reply other threads:[~2005-07-05 19:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 23:03 [PATCH 00/16] Add InfiniBand userspace verbs (direct userspace access) Roland Dreier
2005-06-28 23:03 ` [PATCH 01/16] IB uverbs: core API extensions Roland Dreier
2005-06-28 23:03 ` [PATCH 02/16] IB uverbs: update kernel midlayer for new API Roland Dreier
2005-06-28 23:03 ` [PATCH 03/16] IB uverbs: update mthca " Roland Dreier
2005-06-28 23:03 ` [PATCH 04/16] IB uverbs: add user verbs ABI header Roland Dreier
2005-06-28 23:03 ` [PATCH 05/16] IB uverbs: core implementation Roland Dreier
2005-06-28 23:03 ` [PATCH 06/16] IB uverbs: memory pinning implementation Roland Dreier
2005-06-28 23:03 ` [PATCH 07/16] IB uverbs: hook up Kconfig/Makefile Roland Dreier
2005-06-28 23:03 ` [PATCH 08/16] IB uverbs: add mthca ABI header Roland Dreier
2005-06-28 23:03 ` [PATCH 09/16] IB uverbs: add mthca user doorbell record support Roland Dreier
2005-06-28 23:03 ` [PATCH 10/16] IB uverbs: add mthca user context support Roland Dreier
2005-06-28 23:03 ` [PATCH 11/16] IB uverbs: add mthca mmap support Roland Dreier
2005-06-28 23:03 ` [PATCH 12/16] IB uverbs: add mthca user PD support Roland Dreier
2005-06-28 23:03 ` [PATCH 13/16] IB uverbs: add mthca user MR support Roland Dreier
2005-06-28 23:03 ` [PATCH 14/16] IB uverbs: add mthca user CQ support Roland Dreier
2005-06-28 23:03 ` [PATCH 15/16] IB uverbs: add mthca user QP support Roland Dreier
2005-06-28 23:03 ` [PATCH 16/16] IB uverbs: add documentation file Roland Dreier
2005-06-29 0:10 ` [PATCH 14/16] IB uverbs: add mthca user CQ support Andrew Morton
2005-06-29 16:06 ` Roland Dreier
2005-06-29 0:07 ` [PATCH 12/16] IB uverbs: add mthca user PD support Andrew Morton
2005-06-29 16:06 ` Roland Dreier
2005-06-29 0:05 ` [PATCH 11/16] IB uverbs: add mthca mmap support Andrew Morton
2005-06-29 16:06 ` Roland Dreier
2005-07-05 19:20 ` Roland Dreier [this message]
2005-07-05 20:53 ` Michael S. Tsirkin
2005-07-05 22:07 ` Roland Dreier
2005-06-29 0:02 ` [PATCH 06/16] IB uverbs: memory pinning implementation Andrew Morton
2005-06-29 16:06 ` Roland Dreier
2005-06-29 0:27 ` [PATCH 05/16] IB uverbs: core implementation Greg KH
2005-06-29 1:38 ` [openib-general] " Tom Duffy
2005-06-29 4:13 ` Troy Benjegerdes
2005-06-29 16:12 ` Greg KH
2005-06-29 16:32 ` Troy Benjegerdes
2005-06-29 16:06 ` Roland Dreier
2005-06-29 17:01 ` Roland Dreier
2005-06-29 18:03 ` Greg KH
2005-06-30 3:13 ` [openib-general] " Ronald G. Minnich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52mzp1oy91.fsf@topspin.com \
--to=rolandd@cisco.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox