From: Roland Dreier <roland@topspin.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@osdl.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Centralize i386 Constants
Date: Mon, 16 Aug 2004 10:25:43 -0700 [thread overview]
Message-ID: <52n00vm1uw.fsf@topspin.com> (raw)
In-Reply-To: <1092619849.29612.49.camel@bach> (Rusty Russell's message of "Mon, 16 Aug 2004 11:30:50 +1000")
Rusty> __FIXADDR_TOP and PAGE_OFFSET are hardcoded in various
Rusty> places. I had to change it to run the kernel under
Rusty> qemu-fast, so I wanted to centralize them.
I like this patch -- I recently built a kernel with PAGE_OFFSET
0xb0000000 to avoid highmem on my box with 1G of RAM, based on recent
discussion, and I made the same change to vmlinux.lds.S (although
since <asm-i386/thread_info.h> includes <asm-i386/page.h>, I didn't
bother adding the "#include <asm/page.h>" line).
In any case it seems there is at least one more place where 0xc0000000
is hardcoded in arch/i386. The patch below uses PAGE_OFFSET instead
of 0xc0000000 in doublefault.c's ptr_ok() macro.
- Roland
Signed-off-by: Roland Dreier <roland@topspin.com>
--- linux-2.6.8.1.orig/arch/i386/kernel/doublefault.c 2004-08-14 03:54:50.000000000 -0700
+++ linux-2.6.8.1/arch/i386/kernel/doublefault.c 2004-08-14 10:44:55.000000000 -0700
@@ -13,7 +13,7 @@
static unsigned long doublefault_stack[DOUBLEFAULT_STACKSIZE];
#define STACK_START (unsigned long)(doublefault_stack+DOUBLEFAULT_STACKSIZE)
-#define ptr_ok(x) ((x) > 0xc0000000 && (x) < 0xc1000000)
+#define ptr_ok(x) ((x) > PAGE_OFFSET && (x) < PAGE_OFFSET + 0x1000000)
static void doublefault_fn(void)
{
prev parent reply other threads:[~2004-08-16 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-16 1:30 [PATCH] Centralize i386 Constants Rusty Russell
2004-08-16 17:25 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52n00vm1uw.fsf@topspin.com \
--to=roland@topspin.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).