From: Roland Dreier <roland@topspin.com>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix up RTM_SETLINK handling
Date: 15 Jan 2003 16:22:22 -0800 [thread overview]
Message-ID: <52of6ihrk1.fsf@topspin.com> (raw)
In-Reply-To: <20030115.160716.23576593.davem@redhat.com>
Roland> To call the netdev notifier chain I had to make
Roland> netdev_chain not be static. I added the declaration to
Roland> <linux/netdevice.h> but I am open to other ways to give
Roland> rtnetlink.c access to netdev_chain.
David> Ummm, what is the problem with using
David> register_netdevice_notifier()? It is precisely there so
David> that netdev_chain need not be exported.
do_setlink() needs to do the opposite of registering a notifier --
it's changing an interface's address, so it needs to call the
netdev_chain with NETDEV_CHANGEADDR (just like the handler for
SIOCSIFHWADDR does).
If you prefer, I could add a call_netdevice_notifiers() to dev.c and
leave netdev_chain static. Just let me know and I'll make a new
patch.
Thanks,
Roland
next prev parent reply other threads:[~2003-01-16 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-15 7:01 [PATCH] fix up RTM_SETLINK handling Roland Dreier
2003-01-16 0:07 ` David S. Miller
2003-01-16 0:22 ` Roland Dreier [this message]
2003-01-16 0:13 ` David S. Miller
2003-01-16 1:24 ` Roland Dreier
2003-01-16 1:23 ` David S. Miller
2003-01-16 1:39 ` Roland Dreier
2003-01-16 7:37 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52of6ihrk1.fsf@topspin.com \
--to=roland@topspin.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox