public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <roland@topspin.com>
To: Dave Jones <davej@redhat.com>
Cc: Greg KH <gregkh@suse.de>,
	Grant Grundler <grundler@parisc-linux.org>,
	tom.l.nguyen@intel.com, linux-pci@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: pci_enable_msi() for everyone?
Date: Sat, 04 Jun 2005 07:58:38 -0700	[thread overview]
Message-ID: <52psv2rwwx.fsf@topspin.com> (raw)
In-Reply-To: <20050604072348.GA28293@redhat.com> (Dave Jones's message of "Sat, 4 Jun 2005 03:23:48 -0400")

    Dave> What if MSI support has been disabled in the bridge due to
    Dave> some quirk (like the recent AMD 8111 quirk) ?  Maybe the
    Dave> above function should check pci_msi_enable as well ?

You can't disable MSI at a bridge -- according to the PCI spec, as
soon as a device has the MSI enable turned on, it must start using MSI
for interrupts and must not ever assert an interrupt pine.  The issue
with AMD 8131 is that it doesn't have any MSI support and just
silently throws away MSI messages, and so the host never gets
interrupts from devices in MSI mode.  Which means any device below
such a host bridge better not have MSI or MSI-X enabled.

 - R.

  reply	other threads:[~2005-06-04 15:02 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-03 22:45 pci_enable_msi() for everyone? Greg KH
2005-06-03 23:16 ` Jeff Garzik
2005-06-04  0:01   ` Benjamin Herrenschmidt
2005-06-04  0:08     ` Jeff Garzik
2005-06-04  0:16       ` Benjamin Herrenschmidt
2005-06-04  0:34         ` Jeff Garzik
2005-06-04  6:51   ` Greg KH
2005-06-03 23:36 ` Roland Dreier
2005-06-06 22:58   ` Greg KH
2005-06-07  0:23     ` Roland Dreier
2005-06-07  5:19       ` Greg KH
2005-06-04  1:31 ` Grant Grundler
2005-06-04  6:48   ` Greg KH
2005-06-04  7:05     ` Grant Grundler
2005-06-04  7:18       ` Greg KH
2005-06-04  7:23         ` Dave Jones
2005-06-04 14:58           ` Roland Dreier [this message]
2005-06-06 23:01           ` Greg KH
2005-06-07  0:26             ` Roland Dreier
2005-06-07  5:22               ` Greg KH
2005-06-07  5:46                 ` Adam Belay
2005-06-07 17:43                   ` Luben Tuikov
2005-06-05 22:00         ` Benjamin Herrenschmidt
2005-06-06 23:00           ` Greg KH
2005-06-06 23:56             ` Benjamin Herrenschmidt
2005-06-05 19:46 ` David S. Miller
2005-06-06 22:55   ` Greg KH
2005-06-06 22:59     ` David S. Miller
2005-06-06 23:09       ` Greg KH
2005-06-06 23:08     ` Jeff Garzik
2005-06-06 23:10       ` David S. Miller
2005-06-06 23:13       ` Greg KH
2005-06-06 23:53         ` Jeff Garzik
2005-06-06 23:56           ` Greg KH
2005-06-06 23:58           ` David S. Miller
2005-06-07  4:24       ` Grant Grundler
2005-06-07  0:18     ` Roland Dreier
2005-06-07  5:21       ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2005-06-07 22:33 Nguyen, Tom L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52psv2rwwx.fsf@topspin.com \
    --to=roland@topspin.com \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=grundler@parisc-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=tom.l.nguyen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox