public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <roland@topspin.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, mshefty@ichips.intel.com,
	halr@voltaire.com, openib-general@openib.org
Subject: Re: [-mm patch] drivers/infiniband/hw/mthca/mthca_main.c: remove an unused label
Date: Tue, 05 Apr 2005 09:53:21 -0700	[thread overview]
Message-ID: <52psx9cghq.fsf@topspin.com> (raw)
In-Reply-To: <20050405142449.GF6885@stusta.de> (Adrian Bunk's message of "Tue, 5 Apr 2005 16:24:49 +0200")

    >   CC      drivers/infiniband/hw/mthca/mthca_main.o
    > drivers/infiniband/hw/mthca/mthca_main.c: In function `mthca_init_icm':
    > drivers/infiniband/hw/mthca/mthca_main.c:479: warning: label 
    > `err_unmap_eqp' defined but not used

Thanks, good catch.  I screwed up the error path in that function a
little while merging patches.  Here's the correct fix.


Correct unwinding in error path of mthca_init_icm().

Signed-off-by: Roland Dreier <roland@topspin.com>

--- linux-2.6.12-rc2-mm1.orig/drivers/infiniband/hw/mthca/mthca_main.c	2005-04-05 09:49:02.944473724 -0700
+++ linux-2.6.12-rc2-mm1/drivers/infiniband/hw/mthca/mthca_main.c	2005-04-05 09:49:15.679708865 -0700
@@ -437,7 +437,7 @@
 	if (!mdev->qp_table.rdb_table) {
 		mthca_err(mdev, "Failed to map RDB context memory, aborting\n");
 		err = -ENOMEM;
-		goto err_unmap_rdb;
+		goto err_unmap_eqp;
 	}
 
        mdev->cq_table.table = mthca_alloc_icm_table(mdev, init_hca->cqc_base,

  parent reply	other threads:[~2005-04-05 17:43 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-05  7:05 2.6.12-rc2-mm1 Andrew Morton
2005-04-05  7:21 ` 2.6.12-rc2-mm1 Dave Airlie
2005-04-05  7:33 ` 2.6.12-rc2-mm1 Nick Piggin
2005-04-05  7:59   ` 2.6.12-rc2-mm1 Ingo Molnar
2005-04-05 18:51   ` 2.6.12-rc2-mm1 Siddha, Suresh B
2005-04-05 23:42     ` 2.6.12-rc2-mm1 Nick Piggin
2005-04-06 17:11     ` 2.6.12-rc2-mm1 Nick Piggin
2005-04-08  1:08       ` 2.6.12-rc2-mm1 Siddha, Suresh B
2005-04-08  2:28         ` 2.6.12-rc2-mm1 Nick Piggin
2005-04-05  7:39 ` 2.6.12-rc2-mm1 Brice Goglin
2005-04-05  7:45   ` 2.6.12-rc2-mm1 Andrew Morton
2005-04-05  7:59     ` 2.6.12-rc2-mm1 Brice Goglin
2005-04-05  8:05       ` 2.6.12-rc2-mm1 Andrew Morton
2005-04-07 17:00     ` 2.6.12-rc2-mm1 - printk timing broken Damir Perisa
2005-04-05  8:30   ` 2.6.12-rc2-mm1 Ingo Molnar
2005-04-05  8:40     ` 2.6.12-rc2-mm1 Brice Goglin
2005-04-05 18:34       ` 2.6.12-rc2-mm1 Ingo Molnar
2005-04-06  9:09         ` 2.6.12-rc2-mm1 Brice Goglin
2005-04-05  7:44 ` 2.6.12-rc2-mm1 Christoph Hellwig
2005-04-05  9:07   ` 2.6.12-rc2-mm1 Dave Airlie
2005-04-05  9:20     ` 2.6.12-rc2-mm1 Paul Mackerras
2005-04-05  9:25       ` 2.6.12-rc2-mm1 Dave Airlie
2005-04-05  9:30       ` 2.6.12-rc2-mm1 Christoph Hellwig
2005-04-05  9:44         ` 2.6.12-rc2-mm1 Paul Mackerras
2005-04-05  9:45           ` 2.6.12-rc2-mm1 Christoph Hellwig
2005-04-05  9:51             ` 2.6.12-rc2-mm1 Paul Mackerras
2005-04-05  9:54               ` 2.6.12-rc2-mm1 Christoph Hellwig
2005-04-05  9:58                 ` 2.6.12-rc2-mm1 Dave Airlie
2005-04-05 10:03                   ` 2.6.12-rc2-mm1 Christoph Hellwig
2005-04-05  9:58                 ` 2.6.12-rc2-mm1 Paul Mackerras
2005-04-05  9:33       ` 2.6.12-rc2-mm1 Arjan van de Ven
2005-04-05  9:11   ` 2.6.12-rc2-mm1 Paul Mackerras
2005-04-05  9:12     ` 2.6.12-rc2-mm1 Christoph Hellwig
2005-04-05  9:35       ` 2.6.12-rc2-mm1 Paul Mackerras
2005-04-05  9:36         ` 2.6.12-rc2-mm1 Christoph Hellwig
2005-04-05  7:45 ` 2.6.12-rc2-mm1 Christoph Hellwig
2005-04-05  7:51   ` 2.6.12-rc2-mm1 Andrew Morton
2005-04-05 16:48   ` 2.6.12-rc2-mm1 David Woodhouse
2005-04-05  8:18 ` 2.6.12-rc2-mm1 Brice Goglin
2005-04-05  8:46 ` 2.6.12-rc2-mm1 Rafael J. Wysocki
2005-04-05 10:08 ` 2.6.12-rc2-mm1 Jindrich Makovicka
2005-04-06 22:07   ` 2.6.12-rc2-mm1 Andrew Morton
2005-04-05 10:18 ` 2.6.12-rc2-mm1 Andrey Panin
2005-04-05 12:21 ` [-mm patch] Makefile: fix spaces instead of tab Adrian Bunk
2005-04-05 13:19   ` Sam Ravnborg
2005-04-05 12:40 ` 2.6.12-rc2-mm1 Borislav Petkov
2005-04-05 13:44 ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-05 14:14   ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-05 22:03     ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-06  0:56     ` 2.6.12-rc2-mm1 Andrew Morton
2005-04-06  7:19       ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-06 12:59       ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-06 21:27         ` 2.6.12-rc2-mm1 Andrew Morton
2005-04-07  3:06           ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-07  6:55             ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-08 10:33             ` 2.6.12-rc2-mm1 Pavel Machek
2005-04-10 21:18               ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-10 21:27                 ` 2.6.12-rc2-mm1 Pavel Machek
2005-04-10 22:57                   ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-10 23:00                     ` 2.6.12-rc2-mm1 Pavel Machek
2005-04-11  4:31                       ` 2.6.12-rc2-mm1 Barry K. Nathan
2005-04-11 10:57                         ` swsusp vs. xfs [was Re: 2.6.12-rc2-mm1] Pavel Machek
2005-04-11 23:12                           ` [xfs-masters] " Nathan Scott
2005-04-11 23:51                             ` Pavel Machek
2005-04-12  0:26                               ` Nathan Scott
2005-04-12 11:04                                 ` Pavel Machek
2005-04-12 11:50                                   ` Barry K. Nathan
2005-04-12 12:47                               ` Rafael J. Wysocki
2005-04-11  7:38                     ` 2.6.12-rc2-mm1 Stefan Seyfried
2005-04-05 14:24 ` [-mm patch] drivers/infiniband/hw/mthca/mthca_main.c: remove an unused label Adrian Bunk
2005-04-05 14:37   ` Hal Rosenstock
2005-04-05 16:53   ` Roland Dreier [this message]
2005-04-05 15:45 ` 2.6.12-rc2-mm1 Jan Dittmer
2005-04-05 21:38   ` 2.6.12-rc2-mm1 Sam Ravnborg
2005-04-05 17:11 ` 2.6.12-rc2-mm1 Christophe Saout
2005-04-06  1:44 ` 2.6.12-rc2-mm1 Neil Brown
2005-04-06 22:19   ` 2.6.12-rc2-mm1 Andrew Morton
2005-04-07  0:40 ` 2.6.12-rc2-mm1 Ed Tomlinson
2005-04-07  7:14 ` 2.6.12-rc2-mm1 Mickael Marchand
2005-04-08 18:13   ` [-mm patch] x86_64: kill obsolete check_nmi_watchdog prototype Adrian Bunk
2005-04-08 18:21     ` Mickael Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52psx9cghq.fsf@topspin.com \
    --to=roland@topspin.com \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=halr@voltaire.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mshefty@ichips.intel.com \
    --cc=openib-general@openib.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox