public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rolandd@cisco.com>
To: linux-kernel@vger.kernel.org
Subject: What is struct pci_driver.owner for?
Date: Tue, 18 Oct 2005 13:47:13 -0700	[thread overview]
Message-ID: <52sluymu26.fsf@cisco.com> (raw)

I just noticed that at some point, struct pci_driver grew a .owner
member.  However, only a handful of drivers set it:

    $ grep -r -A10 pci_driver drivers/ | grep owner
    drivers/block/sx8.c-    .owner          = THIS_MODULE,
    drivers/ieee1394/pcilynx.c-     .owner =           THIS_MODULE,
    drivers/net/spider_net.c-       .owner          = THIS_MODULE,
    drivers/video/imsttfb.c-        .owner          = THIS_MODULE,
    drivers/video/kyro/fbdev.c-     .owner          = THIS_MODULE,
    drivers/video/tridentfb.c-      .owner  = THIS_MODULE,

Should all drivers be setting .owner = THIS_MODULE?  Is this a good
kernel janitors task?

 - R.

             reply	other threads:[~2005-10-18 20:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-18 20:47 Roland Dreier [this message]
2005-10-18 20:53 ` What is struct pci_driver.owner for? Jeff Garzik
2005-10-18 20:59   ` Greg KH
2005-10-18 21:04     ` Russell King
2005-10-18 21:06     ` Roland Dreier
2005-10-19 15:42       ` Jiri Slaby
2005-10-19 16:48         ` Roland Dreier
2005-10-19 16:51           ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52sluymu26.fsf@cisco.com \
    --to=rolandd@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox