From: Roland Dreier <roland@topspin.com>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] ppc: fix build with O=$(output_dir)
Date: Thu, 21 Oct 2004 21:20:26 -0700 [thread overview]
Message-ID: <52sm87gz91.fsf@topspin.com> (raw)
In-Reply-To: <20041021203110.GA1532@smtp.west.cox.net> (Tom Rini's message of "Thu, 21 Oct 2004 13:31:10 -0700")
Tom> Can we back this out please? As I noted on lkml once I saw
Tom> this, it still doesn't fix the problem of overwriting files
Tom> in lib/zlib_inflate/ if ZLIB_INFLATE!=n, and adding explicit
Tom> rules for lib/zlib_inflate/foo.c
-> ./foo.o looks quite bad (it's 2 calls if we want checker to get
Tom> invoked, one if we skip doing that). At the end of the
Tom> thread, both Roland and I were hoping Sam knew of a clever
Tom> solution to this.
I can't really object to backing this out, but I'll just point out
that without this patch, in the situations where mainline builds at
all, it still overwrites files in lib/zlib_inflate/. (And builds with
O=xxx don't work at all)
It might make more sense to leave this patch in for now and beg Sam
for a better fix in the future.
Thanks,
Roland
next prev parent reply other threads:[~2004-10-22 4:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200410211910.i9LJAKjf029014@hera.kernel.org>
2004-10-21 20:29 ` [PATCH] ppc: fix build with O=$(output_dir) Tom Rini
2004-10-21 20:31 ` Tom Rini
2004-10-22 4:20 ` Roland Dreier [this message]
2004-10-19 6:48 Roland Dreier
2004-10-19 16:44 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52sm87gz91.fsf@topspin.com \
--to=roland@topspin.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox