From: Roland Dreier <roland@topspin.com>
To: "Nguyen, Tom L" <tom.l.nguyen@intel.com>
Cc: "cramerj" <cramerj@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
"Venkatesan, Ganesh" <ganesh.venkatesan@intel.com>,
<linux-net@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [broken?] Add MSI support to e1000
Date: Mon, 23 Aug 2004 10:25:39 -0700 [thread overview]
Message-ID: <52u0utvka4.fsf@topspin.com> (raw)
In-Reply-To: <C7AB9DA4D0B1F344BF2489FA165E50240619D5A0@orsmsx404.amr.corp.intel.com> (Tom L. Nguyen's message of "Mon, 23 Aug 2004 08:41:06 -0700")
Tom> I do not see anything wrong with the patch and the kernel MSI
Tom> support because it works for a short time. Ganesh may provide
Tom> an answer on the MSI support in e1000 hardware.
Based on the e1000 documentation I have, the only thing required for
the e1000 to use MSI is to set the MSI enable bit in the PCI header.
Of course there may be some e1000 erratum involving MSI but I have not
been able to find any indication that this is the case.
It seems possible that there could be some problem in the core Linux
interrupt code even though some interrupts work -- for example there
could be a race condition triggered when a second interrupt is
delivered while handling the first interrupt. However I couldn't find
any such bug, although I am not at all an expert about low-level
interrupt handling/APIC programming.
- Roland
next prev parent reply other threads:[~2004-08-23 17:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-23 15:41 [PATCH] [broken?] Add MSI support to e1000 Nguyen, Tom L
2004-08-23 17:25 ` Roland Dreier [this message]
2004-08-24 21:49 ` Chris Leech
2004-08-24 23:36 ` Roland Dreier
-- strict thread matches above, loose matches on Subject: below --
2004-08-24 17:40 Nguyen, Tom L
2004-08-24 16:01 Nguyen, Tom L
2004-08-23 23:17 Nguyen, Tom L
2004-08-24 2:15 ` Roland Dreier
2004-08-23 19:41 Nguyen, Tom L
2004-08-23 23:39 ` Andi Kleen
2004-08-24 14:19 ` Roland Dreier
2004-08-23 19:09 Nguyen, Tom L
2004-08-23 19:39 ` Roland Dreier
[not found] <2wpoS-1ai-1@gated-at.bofh.it>
[not found] ` <2wqXF-2jm-29@gated-at.bofh.it>
2004-08-23 18:17 ` Andi Kleen
2004-08-23 18:26 ` Roland Dreier
2004-08-20 21:37 Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52u0utvka4.fsf@topspin.com \
--to=roland@topspin.com \
--cc=cramerj@intel.com \
--cc=ganesh.venkatesan@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox