From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266256AbUHWRei (ORCPT ); Mon, 23 Aug 2004 13:34:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266221AbUHWReN (ORCPT ); Mon, 23 Aug 2004 13:34:13 -0400 Received: from umhlanga.stratnet.net ([12.162.17.40]:60136 "EHLO umhlanga.STRATNET.NET") by vger.kernel.org with ESMTP id S266249AbUHWRan (ORCPT ); Mon, 23 Aug 2004 13:30:43 -0400 To: "Nguyen, Tom L" Cc: "cramerj" , "Ronciak, John" , "Venkatesan, Ganesh" , , Subject: Re: [PATCH] [broken?] Add MSI support to e1000 X-Message-Flag: Warning: May contain useful information References: From: Roland Dreier Date: Mon, 23 Aug 2004 10:25:39 -0700 In-Reply-To: (Tom L. Nguyen's message of "Mon, 23 Aug 2004 08:41:06 -0700") Message-ID: <52u0utvka4.fsf@topspin.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Security Through Obscurity, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 23 Aug 2004 17:25:40.0092 (UTC) FILETIME=[36078BC0:01C48936] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Tom> I do not see anything wrong with the patch and the kernel MSI Tom> support because it works for a short time. Ganesh may provide Tom> an answer on the MSI support in e1000 hardware. Based on the e1000 documentation I have, the only thing required for the e1000 to use MSI is to set the MSI enable bit in the PCI header. Of course there may be some e1000 erratum involving MSI but I have not been able to find any indication that this is the case. It seems possible that there could be some problem in the core Linux interrupt code even though some interrupts work -- for example there could be a race condition triggered when a second interrupt is delivered while handling the first interrupt. However I couldn't find any such bug, although I am not at all an expert about low-level interrupt handling/APIC programming. - Roland