From: Roland Dreier <rolandd@cisco.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
mshefty@ichips.intel.com, halr@voltaire.com,
openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference
Date: Tue, 29 Nov 2005 09:07:58 -0800 [thread overview]
Message-ID: <52veybwff5.fsf@cisco.com> (raw)
In-Reply-To: <20051129123052.GF31395@stusta.de> (Adrian Bunk's message of "Tue, 29 Nov 2005 13:30:52 +0100")
Roland> Is this really important enough for the stable tree?
Adrian> You said it fixed a crash for you.
To trigger the patch, you have to hit the error path, which in
practical terms requires buggy code calling into the function. And
you also have to either be running with CONFIG_DEBUG_SLAB=y or be
extremely unlucky. So I don't think anyone who's not developing IB
driver code could ever hit the crash, and any developers are going to
be running the latest tree anyway.
Adrian> Besides this, it's a small and easy to verify change.
Sure, I don't mind it going into the stable tree. I'm just not sure
it's worth spending everyone's time on it.
- R.
next prev parent reply other threads:[~2005-11-29 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-26 23:37 [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference Adrian Bunk
2005-11-27 23:51 ` Roland Dreier
2005-11-28 0:25 ` Adrian Bunk
2005-11-28 17:59 ` Roland Dreier
2005-11-29 12:30 ` Adrian Bunk
2005-11-29 17:07 ` Roland Dreier [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-23 22:34 Adrian Bunk
2005-11-20 23:14 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52veybwff5.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=halr@voltaire.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mshefty@ichips.intel.com \
--cc=openib-general@openib.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox