From: Roland Dreier <roland@topspin.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: proper way to annotate kernel use of sys_xxx?
Date: Tue, 05 Oct 2004 10:23:45 -0700 [thread overview]
Message-ID: <52vfdprsda.fsf@topspin.com> (raw)
In-Reply-To: <200410051032.39531.arnd@arndb.de> (Arnd Bergmann's message of "Tue, 5 Oct 2004 10:32:33 +0200")
Arnd> In this case, you can easily convert the calls to use
Arnd> filp_open/vfs_read/filp_close, though I'm not sure if that's
Arnd> the correct solution either.
For the do_mounts.c code, I see how the call to sys_open() could be
replaced with a call to filp_open(). However, vfs_read() still takes
a __user pointer for its buffer argument -- in fact, even the
filesystem .aio_read method takes a __user pointer. So I'm not sure
how this code should be fixed.
Thanks,
Roland
prev parent reply other threads:[~2004-10-05 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 5:28 proper way to annotate kernel use of sys_xxx? Roland Dreier
2004-10-05 8:32 ` Arnd Bergmann
2004-10-05 17:23 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52vfdprsda.fsf@topspin.com \
--to=roland@topspin.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).