From: Roland Dreier <roland@topspin.com>
To: Andrew Morton <akpm@digeo.com>
Cc: spstarr@sh0n.net, rml@tech9.net, rmk@arm.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [BUG][2.5.66bk9+] - tty hangings - patches, dmesg & sysctl+T info
Date: 08 Apr 2003 21:52:21 -0700 [thread overview]
Message-ID: <52vfxomfwa.fsf@topspin.com> (raw)
In-Reply-To: <20030408212749.56a8737c.akpm@digeo.com>
Andrew> No, I agree. I don't think pending delayed work should
Andrew> contribute to the count at all.
Andrew> If someone wants to synchronise with the workqueue system
Andrew> they should cancel any delayed work which they own (via
Andrew> cancel_scheduled_work) and then wait on any
Andrew> currently-queued works via flush_scheduled_work().
Andrew> So flush_scheduled_work() only needs to care about
Andrew> currently-queued works, not the ones which are pending a
Andrew> timer event.
Andrew> And flush_scheduled_work() needs to be taught to not lock
Andrew> up if someone keeps re-adding work.
Ah, I see... your patch that added insert_sequence and remove_sequence
was intended to apply on top of the patch that adds
cancel_delayed_work().
Please ignore the reply to your patch that I just sent, I
misunderstood what you were trying to do.
Shawn, I think if you add Andrew's most recent patch on top of what
you were running with, your problem should probably be fixed.
Sorry for the extra noise.
- Roland
next prev parent reply other threads:[~2003-04-09 4:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-06 20:09 [BUG][2.5.66bk9+] - changes to timers still broken - we don't oops anymore Shawn Starr
2003-04-06 20:20 ` Roland Dreier
2003-04-06 20:38 ` Andrew Morton
2003-04-06 21:00 ` Shawn Starr
2003-04-09 2:12 ` [BUG][2.5.66bk9+] - tty hangings - patches, dmesg & sysctl+T info Shawn Starr
2003-04-09 4:12 ` Andrew Morton
2003-04-09 4:47 ` Roland Dreier
2003-04-09 4:56 ` Andrew Morton
2003-04-09 4:16 ` Roland Dreier
2003-04-09 4:27 ` Andrew Morton
2003-04-09 4:52 ` Roland Dreier [this message]
2003-04-09 5:01 ` Shawn Starr
-- strict thread matches above, loose matches on Subject: below --
2003-04-12 16:08 Shawn Starr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52vfxomfwa.fsf@topspin.com \
--to=roland@topspin.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=rml@tech9.net \
--cc=spstarr@sh0n.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox