[PATCH][RFC/v1][0/12] Initial submission of InfiniBand patches for review

[PATCH][RFC/v1][0/12] Initial submission of InfiniBand patches for review

[Roland Dreier]

I'm very happy to be able to post an initial version of InfiniBand
patches for review.  Although this code should be far closer to kernel
coding standards than previous open source InfiniBand drivers, this
initial posting should be treated as a request for comments and not a
request for inclusion; our ultimate goal is to have these drivers
included in the mainline kernel, but we expect that fixes and
improvements will need to be made before the code is completely
acceptable.

These patches add a minimal but complete level of InfiniBand support,
including an IB midlayer, a low-level driver for Mellanox HCAs, an
IP-over-InfiniBand driver, and a mechanism for MADs (management
datagrams) to be passed to and from userspace.  This means that these
patches are all that is required for the kernel to bring up and use an
IP-over-InfiniBand link.  (The OpenSM subnet manager has not been
ported to this kernel API yet, although this work is underway.  This
means that at the moment, a kernel with these patches cannot be used
to bring up a fabric; however, the kernel side is complete)

The code has not been through extreme stress testing yet, but it has
been used successfully on i386, x86_64, ppc64, ia64 and sparc64
systems, including mixed 32/64 systems.

Feedback on both details of the code as well as the high-level
organization of the code will be very much appreciated.  For example,
the current set of patches puts include files in driver/infiniband/include;
would it be preferred to put include files in include/linux/infiniband/,
directly in include/linux, or perhaps in include/infiniband?

We would also like to explore the best avenue for having these patches
merged.  It may be desirable for the patches to spend some time in -mm
before moving into Linus's kernel; on the other hand, the patches make
only very minimal and safe changes outside of drivers/infiniband, so
it is quite reasonable to merge them directly into the mainline
kernel.  Although 2.6.10 is now closed, 2.6.11 will probably be open
by the time the review process is complete.

We look forward to the community's comments and criticisms!

Thanks,
  Roland Dreier
  OpenIB Alliance
  www.openib.org

Re: [PATCH][RFC/v1][0/12] Initial submission of InfiniBand patches for review

[Greg KH]

On Mon, Nov 22, 2004 at 07:13:24AM -0800, Roland Dreier wrote:
> organization of the code will be very much appreciated.  For example,
> the current set of patches puts include files in driver/infiniband/include;
> would it be preferred to put include files in include/linux/infiniband/,
> directly in include/linux, or perhaps in include/infiniband?

Who would be including these files, only drivers in drivers/infiniband?
Or from files in other parts of the kernel?

If from other parts of the kernel, use include/linux/infiniband.

thanks,

greg k-h

Re: [PATCH][RFC/v1][0/12] Initial submission of InfiniBand patches for review

[Roland Dreier]

    Greg> Who would be including these files, only drivers in
    Greg> drivers/infiniband?  Or from files in other parts of the
    Greg> kernel?

In the current patchset all the code is under drivers/infiniband.

    Greg> If from other parts of the kernel, use include/linux/infiniband.

That's one vote for include/linux/infiniband and two votes for
include/infiniband so far...

 - R.

Re: [PATCH][RFC/v1][0/12] Initial submission of InfiniBand patches for review

[Greg KH]

On Mon, Nov 22, 2004 at 02:50:41PM -0800, Roland Dreier wrote:
>     Greg> Who would be including these files, only drivers in
>     Greg> drivers/infiniband?  Or from files in other parts of the
>     Greg> kernel?
> 
> In the current patchset all the code is under drivers/infiniband.

Then it should just stay in that directory.  Well, that's my preference
anyway :)

thanks,

greg k-h

Re: [PATCH][RFC/v1][0/12] Initial submission of InfiniBand patches for review

[Arnd Bergmann]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

On Maandag 22 November 2004 16:13, Roland Dreier wrote:
> I'm very happy to be able to post an initial version of InfiniBand
> patches for review. 

Patches 1, 3 and 5 didn't make it to lkml. Did you hit the 100kb size
limit for mails?

	Arnd <><



[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH][RFC/v1][0/12] Initial submission of InfiniBand patches for review

[Roland Dreier]

    Arnd> Patches 1, 3 and 5 didn't make it to lkml. Did you hit the
    Arnd> 100kb size limit for mails?

Ah, that must be what happened.  I was confused because gmane.org did
pick them up, but I think that's because gmane is also subscribed to
openib-general (which is cc'ed).

I'll reroll the patches, splitting the too-large pieces, and send
soon.

Thanks,
  Roland