public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <roland@topspin.com>
To: Kevin Corry <corryk@us.ibm.com>
Cc: Linux Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/8] dm: prevent possible buffer overflow in ioctl interface
Date: 27 Feb 2003 08:25:25 -0800	[thread overview]
Message-ID: <52y941pu6i.fsf@topspin.com> (raw)
In-Reply-To: <03022708365304.05199@boiler>

   > +	char *name = kmalloc(DM_NAME_LEN + strlen(DM_DIR) + 1);
   > +	if (!name) {
   > +		return -ENOMEM;
   > +	}

Also, kmalloc() needs a second "GFP_xxx" parameter (I guess GFP_KERNEL
in this case, although I don't know the context this function is
called from).

 - Roland


  reply	other threads:[~2003-02-27 16:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-26 17:05 device-mapper patchset 2.5.63-dm-1 Joe Thornber
2003-02-26 17:08 ` [PATCH 1/8] dm: ioctl interface wasn't dropping a table reference Joe Thornber
2003-02-26 17:08 ` [PATCH 2/8] dm: __LOW macro fix no. 1 Joe Thornber
2003-02-26 17:09 ` [PATCH 3/8] dm: prevent possible buffer overflow in ioctl interface Joe Thornber
2003-02-26 21:04   ` Horst von Brand
2003-02-27 14:20     ` Kevin Corry
2003-02-27 14:36       ` Kevin Corry
2003-02-27 16:25         ` Roland Dreier [this message]
2003-02-27 16:34           ` Kevin Corry
2003-02-27 22:05           ` Kevin Corry
2003-02-26 17:10 ` [PATCH 4/8] dm: deregister the misc device before removing /dev/mapper Joe Thornber
2003-02-26 17:11 ` [PATCH 5/8] dm: bug in error path for unknown target type Joe Thornber
2003-02-26 17:11 ` [PATCH 6/8] dm: allow slashes in dm device names Joe Thornber
2003-02-26 17:38   ` Greg KH
2003-02-26 18:17     ` Kevin Corry
2003-02-26 18:20       ` Greg KH
2003-02-26 17:12 ` [PATCH 7/8] dm: __LOW macro fix no. 2 Joe Thornber
2003-02-26 18:14   ` Greg KH
2003-02-27  8:55     ` Joe Thornber
2003-02-27  9:55     ` Joe Thornber
2003-02-27 16:17       ` Horst von Brand
2003-02-27 16:33         ` Joe Thornber
2003-02-27 17:47       ` Greg KH
2003-02-27  9:34   ` Jakob Oestergaard
2003-02-27 10:01     ` Joe Thornber
2003-02-27 12:55       ` Jakob Oestergaard
2003-02-26 17:13 ` [PATCH 8/8] dm: return correct error codes from dm_table_add_target() Joe Thornber
     [not found] <OF06EBF3D5.39937A14-ON87256CDB.004FD627@us.ibm.com>
2003-02-28 14:59 ` [PATCH 3/8] dm: prevent possible buffer overflow in ioctl interface Kevin Corry
2003-02-28 18:14   ` Horst von Brand
2003-02-28 18:31     ` Kevin Corry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52y941pu6i.fsf@topspin.com \
    --to=roland@topspin.com \
    --cc=corryk@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox