From: Roland Dreier <rolandd@cisco.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Kylene Jo Hall <kjhall@us.ibm.com>,
selhorst@crypto.rub.de, linux-kernel@vger.kernel.org,
castet.matthieu@free.fr
Subject: Re: [PATCH] Infineon TPM: move infineon driver off pci_dev
Date: Thu, 27 Oct 2005 15:03:49 -0700 [thread overview]
Message-ID: <52zmouvcqi.fsf@cisco.com> (raw)
In-Reply-To: <20051027145535.0741b647.akpm@osdl.org> (Andrew Morton's message of "Thu, 27 Oct 2005 14:55:35 -0700")
Andrew, a few comments on your trivial comments:
> -static int tpm_atml_send(struct tpm_chip *chip, u8 * buf, size_t count)
> +static int tpm_atml_send(struct tpm_chip *chip, u8 *buf, size_t count)
There's still an extra space there I think.
> - data = kmalloc(READ_PUBEK_RESULT_SIZE, GFP_KERNEL);
> + data = kxalloc(READ_PUBEK_RESULT_SIZE, GFP_KERNEL);
When did we add kxalloc()? And what does it do?
> -ssize_t tpm_write(struct file * file, const char __user * buf,
> +ssize_t tpm_write(struct file * file, const char __user *buf,
Why delete one space between * and buf but not the one between * and file?
- R.
next prev parent reply other threads:[~2005-10-27 22:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-26 17:11 [PATCH] Infineon TPM: move infineon driver off pci_dev Marcel Selhorst
2005-10-26 17:23 ` Kylene Jo Hall
2005-10-26 17:41 ` matthieu castet
2005-10-26 19:53 ` Marcel Selhorst
2005-10-27 11:22 ` Marcel Selhorst
2005-10-27 14:07 ` Kylene Jo Hall
2005-10-27 21:55 ` Andrew Morton
2005-10-27 22:03 ` Roland Dreier [this message]
2005-10-27 22:26 ` Andrew Morton
2005-10-28 14:22 ` Kylene Jo Hall
2005-11-11 20:11 ` [PATCH] TPM: cleanups Kylene Jo Hall
2005-11-11 23:08 ` Kylene Jo Hall
2005-11-12 21:48 ` Andrew Morton
2005-11-16 22:48 ` Kylene Jo Hall
2005-10-27 21:33 ` [PATCH] Infineon TPM: move infineon driver off pci_dev Andrew Morton
2005-10-28 5:23 ` Marcel Selhorst
2005-10-27 21:42 ` matthieu castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52zmouvcqi.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=akpm@osdl.org \
--cc=castet.matthieu@free.fr \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=selhorst@crypto.rub.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox