public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arch: avr32: include: asm: Kbuild: add generic "vga.h"
@ 2014-02-16 11:36 Chen Gang
  2014-02-17  9:52 ` Hans-Christian Egtvedt
  0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-02-16 11:36 UTC (permalink / raw)
  To: Håvard Skinnemoen, Hans-Christian Egtvedt
  Cc: Peter Zijlstra, Ingo Molnar, tim.c.chen, liuj97, David Miller,
	rostedt, linux-kernel@vger.kernel.org

Need add generic "vga.h", or can not pass building for allmodconfig,
the related error:

    CC [M]  drivers/gpu/drm/drm_irq.o
  In file included from include/linux/vgaarb.h:34,
                   from drivers/gpu/drm/drm_irq.c:42:
  include/video/vga.h:22:21: error: asm/vga.h: No such file or directory


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/avr32/include/asm/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/avr32/include/asm/Kbuild b/arch/avr32/include/asm/Kbuild
index 8b398ff..00a0f3c 100644
--- a/arch/avr32/include/asm/Kbuild
+++ b/arch/avr32/include/asm/Kbuild
@@ -19,4 +19,5 @@ generic-y += scatterlist.h
 generic-y += sections.h
 generic-y += topology.h
 generic-y += trace_clock.h
+generic-y += vga.h
 generic-y += xor.h
-- 
1.7.11.7

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arch: avr32: include: asm: Kbuild: add generic "vga.h"
  2014-02-16 11:36 [PATCH] arch: avr32: include: asm: Kbuild: add generic "vga.h" Chen Gang
@ 2014-02-17  9:52 ` Hans-Christian Egtvedt
  0 siblings, 0 replies; 2+ messages in thread
From: Hans-Christian Egtvedt @ 2014-02-17  9:52 UTC (permalink / raw)
  To: Chen Gang
  Cc: Håvard Skinnemoen, Peter Zijlstra, Ingo Molnar, tim.c.chen,
	liuj97, David Miller, rostedt, linux-kernel@vger.kernel.org

Around Sun 16 Feb 2014 19:36:06 +0800 or thereabout, Chen Gang wrote:
> Need add generic "vga.h", or can not pass building for allmodconfig,
> the related error:
> 
>     CC [M]  drivers/gpu/drm/drm_irq.o
>   In file included from include/linux/vgaarb.h:34,
>                    from drivers/gpu/drm/drm_irq.c:42:
>   include/video/vga.h:22:21: error: asm/vga.h: No such file or directory

Does this really makes sense for an architecture that only supports framebuffer?

I even recall doing something like this in the past, but the change probably
fell between chairs.

> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

> ---
>  arch/avr32/include/asm/Kbuild | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/avr32/include/asm/Kbuild b/arch/avr32/include/asm/Kbuild
> index 8b398ff..00a0f3c 100644
> --- a/arch/avr32/include/asm/Kbuild
> +++ b/arch/avr32/include/asm/Kbuild
> @@ -19,4 +19,5 @@ generic-y += scatterlist.h
>  generic-y += sections.h
>  generic-y += topology.h
>  generic-y += trace_clock.h
> +generic-y += vga.h
>  generic-y += xor.h
-- 
mvh
Hans-Christian Egtvedt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-17  9:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-16 11:36 [PATCH] arch: avr32: include: asm: Kbuild: add generic "vga.h" Chen Gang
2014-02-17  9:52 ` Hans-Christian Egtvedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox