From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761479AbcALOue (ORCPT ); Tue, 12 Jan 2016 09:50:34 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:51554 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606AbcALOuc (ORCPT ); Tue, 12 Jan 2016 09:50:32 -0500 From: Arnd Bergmann To: Srinivas Kandagatla Cc: linux-arm-kernel@lists.infradead.org, andy.gross@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Date: Tue, 12 Jan 2016 15:49:52 +0100 Message-ID: <5301475.Pt8xa8PKiv@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56950B4D.3030707@linaro.org> References: <1452606358-24569-1-git-send-email-srinivas.kandagatla@linaro.org> <18094818.3Fy0P66y0u@wuerfel> <56950B4D.3030707@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:YSnw+x8RAU6duh9T6x2/xkHvdfz+gBF98w63KSDuwittXhqKhSk NMUTDdmUXNY76d+i++4PYji3P4z/YRPvgwkVLY1cTsna2aW8vbPoXZGrhcLazUrsSyPgHsM YWfT4xrv1hREyCl1o9N3Vy9ck86rg8LcqMu/RJ2gMmTb5ZJZ5i78C81XkGBH+4RPVzIuAOZ 43TxWxljY9P7iROcx95PQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:+iRYIQkuwuM=:Wf9UDfuLOXQi2CWGSIyqK9 JojWQV6RaqLBcG5U4DXSjJz1P3BbvZ6ujYg9cwdQugfJTRp9d9Jpzj/SvX86CSz/s+WP8Swhn yWz9OmBWhcbmc4AE2ax3pAV/JHdYyvB8s+Yo9RrOvkWEJLYIe++5nm2vF+Xg8jCk5Yx/Rru7z ZZiKU1YeszhfI5F3clbEqIHvZLrsQTRwPYWwApL7Jaah8Lw08cPiKQ9YpgzPvgWOGN8MGvjX7 zeNBL2bQj1RdX97KOet3mY9102DcLkrtMb4BRhR4FQj34ecWbQzSGFwM3fnCcZ0HDWqnDVDEa 0DZ7IoX5fPkTfFD7BIfUscBVY+dJlCfu3BDRFJtrghsWoj2ivrpq46ml8EmRbyoOf9E9zgMlG 5UoLnpachD+aqb44/zOphClaMyw0kaqspvZ9sbtjxbCQbY7eRXnj+DDaCAHNSO00e5svvYWyJ 1ciVq5WH69Z1oo5XUFOq2CD77/avh5KZ9yz9RasEoRAd+L2zYmARBkSzacqQ2gqNc1mB9H75L nR/cx2PZFJ5XdLngNYMGBlGiTZ0Z4PDteVHqVW+CSTskbjGWnGJvEydvuTrS++QNLKzwVOMS3 idpCPmVHIAtRytnhO/3FopjmCCHlwRUy2iWtwzcNbShaZ7rS3a0pD4B64IKfB6arz87ySar5T JW10AG4AP/PWK8mChpX3kHqu0ZaG+oyzugb3n1rV39T3V4ROD91hGnXv9GlwY6CT62pd3VdOG varCOg94DlhC3Zen Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 12 January 2016 14:18:53 Srinivas Kandagatla wrote: > On 12/01/16 14:00, Arnd Bergmann wrote: > > On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote: > >> To be consistent with other nodes move sdhci node under the soc node, > >> rather than using lable references. > >> > >> Signed-off-by: Srinivas Kandagatla > >> > > > > Maybe remove the label as well if you are no longer using it? > Label "sdhc_1" in this case is used in aliases node. > Ok, nevermind then. > My understanding so far was qcom specific dt want to use hierarchical dt > nodes in the board files, but this brings the question of should we > delete all the unused labels. > > IMO, some unused labels are harmless and would give more consistency to > the reader, removing them might not add great value. Fair enough. Arnd