public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] IA64, sba_iommu: fix section mismatch
@ 2014-02-17  5:58 Jiang Liu
  2014-02-17  6:57 ` Yijing Wang
  2014-02-17  7:37 ` [PATCH v2] " Jiang Liu
  0 siblings, 2 replies; 4+ messages in thread
From: Jiang Liu @ 2014-02-17  5:58 UTC (permalink / raw)
  To: Tony Luck, Fenghua Yu, Rafael J. Wysocki
  Cc: Jiang Liu, linux-ia64, linux-kernel

Fix the section mismatch warning by remove __init annotate for function
acpi_sba_ioc_add() because it may be called at runtime.

WARNING: vmlinux.o(.data+0x66ee0): Section mismatch in reference from the variable acpi_sba_ioc_handler to the function .init.text:acpi_sba_ioc_add()
The variable acpi_sba_ioc_handler references
the function __init acpi_sba_ioc_add()

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
 arch/ia64/hp/common/sba_iommu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/ia64/hp/common/sba_iommu.c b/arch/ia64/hp/common/sba_iommu.c
index 8e858b5..c9d6f0b 100644
--- a/arch/ia64/hp/common/sba_iommu.c
+++ b/arch/ia64/hp/common/sba_iommu.c
@@ -2041,7 +2041,7 @@ sba_map_ioc_to_node(struct ioc *ioc, acpi_handle handle)
 #define sba_map_ioc_to_node(ioc, handle)
 #endif
 
-static int __init
+static int
 acpi_sba_ioc_add(struct acpi_device *device,
 		 const struct acpi_device_id *not_used)
 {
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] IA64, sba_iommu: fix section mismatch
  2014-02-17  5:58 [PATCH] IA64, sba_iommu: fix section mismatch Jiang Liu
@ 2014-02-17  6:57 ` Yijing Wang
  2014-02-17  7:08   ` Jiang Liu
  2014-02-17  7:37 ` [PATCH v2] " Jiang Liu
  1 sibling, 1 reply; 4+ messages in thread
From: Yijing Wang @ 2014-02-17  6:57 UTC (permalink / raw)
  To: Jiang Liu, Tony Luck, Fenghua Yu, Rafael J. Wysocki
  Cc: linux-ia64, linux-kernel

> -static int __init
> +static int
>  acpi_sba_ioc_add(struct acpi_device *device,
>  		 const struct acpi_device_id *not_used)
>  {
> 

Hi Gerry,
   ioc_init() and sba_map_ioc_to_node() in this function seems also have the __init annotate.


-- 
Thanks!
Yijing


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] IA64, sba_iommu: fix section mismatch
  2014-02-17  6:57 ` Yijing Wang
@ 2014-02-17  7:08   ` Jiang Liu
  0 siblings, 0 replies; 4+ messages in thread
From: Jiang Liu @ 2014-02-17  7:08 UTC (permalink / raw)
  To: Yijing Wang, Tony Luck, Fenghua Yu, Rafael J. Wysocki
  Cc: linux-ia64, linux-kernel

Thanks for reminder, will send out v2.

On 2014/2/17 14:57, Yijing Wang wrote:
>> -static int __init
>> +static int
>>  acpi_sba_ioc_add(struct acpi_device *device,
>>  		 const struct acpi_device_id *not_used)
>>  {
>>
> 
> Hi Gerry,
>    ioc_init() and sba_map_ioc_to_node() in this function seems also have the __init annotate.
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] IA64, sba_iommu: fix section mismatch
  2014-02-17  5:58 [PATCH] IA64, sba_iommu: fix section mismatch Jiang Liu
  2014-02-17  6:57 ` Yijing Wang
@ 2014-02-17  7:37 ` Jiang Liu
  1 sibling, 0 replies; 4+ messages in thread
From: Jiang Liu @ 2014-02-17  7:37 UTC (permalink / raw)
  To: Yijing Wang, Tony Luck, Fenghua Yu, Rafael J. Wysocki, Jiang Liu
  Cc: linux-ia64, linux-kernel

Fix the section mismatch warning by remove __init annotate for function
acpi_sba_ioc_add() because it may be called at runtime.

WARNING: vmlinux.o(.data+0x66ee0): Section mismatch in reference from the variable acpi_sba_ioc_handler to the function .init.text:acpi_sba_ioc_add()
The variable acpi_sba_ioc_handler references
the function __init acpi_sba_ioc_add()

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
 arch/ia64/hp/common/sba_iommu.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/ia64/hp/common/sba_iommu.c b/arch/ia64/hp/common/sba_iommu.c
index 8e858b5..30c43d3 100644
--- a/arch/ia64/hp/common/sba_iommu.c
+++ b/arch/ia64/hp/common/sba_iommu.c
@@ -1596,7 +1596,7 @@ static void sba_unmap_sg_attrs(struct device *dev, struct scatterlist *sglist,
 *
 ***************************************************************/
 
-static void __init
+static void
 ioc_iova_init(struct ioc *ioc)
 {
 	int tcnfg;
@@ -1807,7 +1807,7 @@ static struct ioc_iommu ioc_iommu_info[] __initdata = {
 	{ SX2000_IOC_ID, "sx2000", NULL },
 };
 
-static struct ioc * __init
+static struct ioc *
 ioc_init(unsigned long hpa, void *handle)
 {
 	struct ioc *ioc;
@@ -2041,7 +2041,7 @@ sba_map_ioc_to_node(struct ioc *ioc, acpi_handle handle)
 #define sba_map_ioc_to_node(ioc, handle)
 #endif
 
-static int __init
+static int
 acpi_sba_ioc_add(struct acpi_device *device,
 		 const struct acpi_device_id *not_used)
 {
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-02-17  7:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-17  5:58 [PATCH] IA64, sba_iommu: fix section mismatch Jiang Liu
2014-02-17  6:57 ` Yijing Wang
2014-02-17  7:08   ` Jiang Liu
2014-02-17  7:37 ` [PATCH v2] " Jiang Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox