Re: [PATCH] Revert "ACPI / video: Add HP EliteBook Revolve 810 to the blacklist"

[Aaron Lu <aaron.lu@intel.com>]

On 02/17/2014 05:56 PM, Takashi Iwai wrote:
> At Mon, 17 Feb 2014 13:52:46 +0800,
> Aaron Lu wrote:
>>
>> On 02/15/2014 06:21 AM, Rafael J. Wysocki wrote:
>>> On Friday, February 14, 2014 05:26:01 PM Mika Westerberg wrote:
>>>> On Fri, Feb 14, 2014 at 03:46:20PM +0100, Takashi Iwai wrote:
>>>>> The acpi_osi blacklist is just a workaround, and if we have better
>>>>> solutions, it should be removed.  That's why I'm asking it.
>>>>>
>>>>> So, after removing acpi_osi blacklist, and keeping your video
>>>>> blacklist patch, the backlight works?
>>>>
>>>> Yes, the backlight works (there is only intel_backlight listed under
>>>> /sys/class/backlight).
>>>>
>>>>> If yes, as mentioned, we should think of rather extending this video
>>>>> blacklist to more EliteBook G1 and ProBook G1 machines, and remove
>>>>> acpi_osi blacklist instead.
>>>>
>>>> Makes sense to me. (Well, I'm fine as long as backlight on my machine works
>>>> ;-))
>>>>
>>>> Aaron, Rafael, any comments on this?
>>>
>>> I generally agree with Takashi, but I'm not sure what to do for 3.14.
>>
>> I can re-base the previously sent patch titled:
>> [PATCH] ACPI / video: Add systems that should favor native backlight interface
>> And put Mika's system into the DMI table that will use native backlight
>> interface in video module and remove it from video_detect's DMI table at
>> the same time. Does this sound OK?
> 
> Rather put more generic DMI entries for the recent HP ProBook and
> EliteBook machines as in acpi_osi blacklist:
> 
> 	{
> 	.callback = dmi_disable_osi_win8,
> 	.ident = "HP ProBook 2013 models",
> 	.matches = {
> 		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook "),
> 		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
> 		},
> 	},
> 	{
> 	.callback = dmi_disable_osi_win8,
> 	.ident = "HP EliteBook 2013 models",
> 	.matches = {
> 		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
> 		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
> 		},
> 	},
> 	{
> 	.callback = dmi_disable_osi_win8,
> 	.ident = "HP ZBook 14",
> 	.matches = {
> 		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 14"),
> 		},
> 	},
> 	{
> 	.callback = dmi_disable_osi_win8,
> 	.ident = "HP ZBook 15",
> 	.matches = {
> 		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 15"),
> 		},
> 	},
> 	{
> 	.callback = dmi_disable_osi_win8,
> 	.ident = "HP ZBook 17",
> 	.matches = {
> 		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 17"),
> 		},
> 	},
> 	{
> 	.callback = dmi_disable_osi_win8,
> 	.ident = "HP EliteBook 8780w",
> 	.matches = {
> 		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> 		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
> 		},
> 	},
> 
> All these are known to have different behavior with Win8, including
> the broken ACPI backlight.  Once after merging that patch, we can
> revert the commit 2d4054d84224.

OK, thanks for the info.
I'll add the above laptops to the video module's use_native_backlight
DMI table.

Thanks,
Aaron

> 
> I suppose it'd be OK for to do these for 3.14, since the acpi_osi
> commit was merged first in 3.14.  Then we can continue fixing in a
> saner way.
> 
> 
> thanks,
> 
> Takashi
>