From: Ian Abbott <abbotti@mev.co.uk>
To: Chase Southwood <chase.southwood@yahoo.com>, gregkh@linuxfoundation.org
Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Staging: comedi: addi-data: convert printk() to dev_err()
Date: Mon, 17 Feb 2014 13:17:50 +0000 [thread overview]
Message-ID: <53020BFE.9020400@mev.co.uk> (raw)
In-Reply-To: <1392540082-26064-1-git-send-email-chase.southwood@yahoo.com>
On 2014-02-16 08:41, Chase Southwood wrote:
> This patch for hwdrv_apci035.c changes a printk() call to a dev_err call
> since this is generally preferred.
>
> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
> ---
> drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
> index 90d5801..f02b714 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c
> @@ -227,7 +227,7 @@ static int i_APCI035_ConfigTimerWatchdog(struct comedi_device *dev,
> ui_Command = ui_Command & 0xFFF819E2UL;
>
> } else {
> - printk("\n The parameter for Timer/watchdog selection is in error\n");
> + dev_err(dev->class_dev, "\n The parameter for Timer/watchdog selection is in error\n");
> return -EINVAL;
> }
> }
>
It'd be great if you could get rid of the initial "\n " in the error
string too.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2014-02-17 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 8:40 [PATCH 1/4] Staging: comedi: addi-data: fix brace-related coding style issues in hwdrv_apci035.c Chase Southwood
2014-02-16 8:41 ` [PATCH 2/4] Staging: comedi: addi-data: cleanup comments " Chase Southwood
2014-02-17 13:16 ` Ian Abbott
2014-02-16 8:41 ` [PATCH 3/4] Staging: comedi: addi-data: convert printk() to dev_err() Chase Southwood
2014-02-17 13:17 ` Ian Abbott [this message]
2014-02-17 20:47 ` Chase Southwood
2014-02-18 6:34 ` [PATCH 3/4 v2] " Chase Southwood
2014-02-18 10:52 ` Ian Abbott
2014-02-16 8:41 ` [PATCH 4/4] Staging: comedi: addi-data: do not initialize statics to 0 in hwdrv_apci035.c Chase Southwood
2014-02-17 13:22 ` Ian Abbott
2014-02-17 13:16 ` [PATCH 1/4] Staging: comedi: addi-data: fix brace-related coding style issues " Ian Abbott
2014-02-17 20:45 ` Chase Southwood
2014-02-18 10:59 ` Dan Carpenter
2014-02-19 1:25 ` Chase Southwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53020BFE.9020400@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=chase.southwood@yahoo.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox