Re: [PATCH v2] clk: respect the clock dependencies in of_clk_init

[Gregory CLEMENT <gregory.clement@free-electrons.com>]

Hi Mike,

I would like to know if you consider to take the following patch.
If you don't then I will have to amend the patch set adding support
to Armada 375/38x SoC with the same kind of solution that Sebastian
used for the other mvebu clocks.

Thanks,

Gregory


On 11/02/2014 17:32, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 10 Feb 2014 18:42:59 +0100, Gregory CLEMENT wrote:
>> Until now the clock providers were initialized in the order found in
>> the device tree. This led to have the dependencies between the clocks
>> not respected: children clocks could be initialized before their
>> parent clocks.
>>
>> Instead of forcing each platform to manage its own initialization order,
>> this patch adds this work inside the framework itself.
>>
>> Using the data of the device tree the of_clk_init function now delayed
>> the initialization of a clock provider if its parent provider was not
>> ready yet.
>>
>> The strict dependency check (all parents of a given clk must be
>> initialized) was added by Boris BREZILLON
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> ---
>>
>> Since the v1, I have merged the  strict dependency check from Boris.
>> And of course tested on my Armada 370 and Armada XP based board
>>
>>  drivers/clk/clk.c | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++--
>>  1 file changed, 106 insertions(+), 3 deletions(-)
> 
> Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> On the newly proposed Armada 375 platform.
> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com