linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Denis Turischev <denis.turischev@compulab.co.il>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
Date: Tue, 18 Feb 2014 09:42:39 +0200	[thread overview]
Message-ID: <53030EEF.7090708@compulab.co.il> (raw)
In-Reply-To: <52F0CAB8.20803@compulab.co.il>

The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.

The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.

Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
 drivers/usb/host/xhci-pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		 */
 		if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
 			xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+		xhci->quirks |= XHCI_SPURIOUS_REBOOT;
 	}
 	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
 			pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-- 1.8.1.2



  reply	other threads:[~2014-02-18  7:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 16:29 xhci: Switch Intel Lynx Point ports to EHCI on shutdown Denis Turischev
2013-12-19 16:38 ` Greg KH
2013-12-19 17:07 ` [PATCH v1] " Denis Turischev
2013-12-19 18:21   ` Sarah Sharp
2013-12-20 10:41     ` Denis Turischev
2013-12-20 23:45       ` Sarah Sharp
2013-12-21 16:45         ` Holger Freyther
2013-12-22  7:47         ` Denis Turischev
2014-01-03  0:03           ` Sarah Sharp
2014-01-03  3:40             ` littlebat
2014-01-03 18:14             ` Oliver Neukum
2014-01-03 19:34             ` art1
2014-01-06 12:34             ` Denis Turischev
2014-01-07 10:03               ` Takashi Iwai
2014-01-07 23:11                 ` Sarah Sharp
2014-01-08 12:57                   ` Denis Turischev
2014-02-04 11:10 ` [PATCH] " Denis Turischev
2014-02-18  7:42   ` Denis Turischev [this message]
2014-02-18 18:54     ` [RESEND] " Sarah Sharp
  -- strict thread matches above, loose matches on Subject: below --
2014-03-07  9:40 Denis Turischev
2014-03-09 12:43 Denis Turischev
2014-03-21 10:01 Denis Turischev
2014-03-21 12:10 ` Mathias Nyman
2014-04-22 11:04   ` Denis Turischev
2014-04-22 12:26     ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53030EEF.7090708@compulab.co.il \
    --to=denis.turischev@compulab.co.il \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).