From: Michal Simek <monstr@monstr.eu>
To: Guenter Roeck <linux@roeck-us.net>
Cc: microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org,
achew@nvidia.com
Subject: Re: [PATCH v2] microblaze: Rename global function heartbeat()
Date: Tue, 18 Feb 2014 17:10:01 +0100 [thread overview]
Message-ID: <530385D9.5090005@monstr.eu> (raw)
In-Reply-To: <1392706014-23332-1-git-send-email-linux@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On 02/18/2014 07:46 AM, Guenter Roeck wrote:
> microblaze:allmodconfig complains for some configurations that 'heartbeat'
> is redefined as different kind of symbol. This is seen in test compiles
> of watchdog drivers, which often use 'heartbeat' as ststic variable.
>
> Since 'heartbeat' is an unfortunate name for a global function,
> rename it to microblaze_heartbeat. Also rename the setup function
> to microblaze_setup_heartbeat.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Use microblaze_ instead of xilinx_ as function prefix.
>
> arch/microblaze/include/asm/setup.h | 4 ++--
> arch/microblaze/kernel/heartbeat.c | 4 ++--
> arch/microblaze/kernel/timer.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
Applied. both to microblaze next branch.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2014-02-18 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 6:46 [PATCH v2] microblaze: Rename global function heartbeat() Guenter Roeck
2014-02-18 16:10 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530385D9.5090005@monstr.eu \
--to=monstr@monstr.eu \
--cc=achew@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=microblaze-uclinux@itee.uq.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox