public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtip32xx: Reduce the number of unaligned writes to 2
@ 2014-02-18 21:46 Asai Thambi S P
  2014-02-18 22:48 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Asai Thambi S P @ 2014-02-18 21:46 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-kernel, Sam Bradshaw

Hi Jens,

Please include this for 3.14. It is a trivial change, hope it should be ok.

--
Regards,
Asai


After several experiments, deduced the the optimal number of unaligned
writes to be 2. Changing the value accordingly.

Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
Signed-off-by: Sam Bradshaw <sbradshaw@micron.com>
---
 drivers/block/mtip32xx/mtip32xx.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.h
b/drivers/block/mtip32xx/mtip32xx.h
index b52e9a6..54174cb 100644
--- a/drivers/block/mtip32xx/mtip32xx.h
+++ b/drivers/block/mtip32xx/mtip32xx.h
@@ -53,7 +53,7 @@
 #define MTIP_FTL_REBUILD_TIMEOUT_MS    2400000

 /* unaligned IO handling */
-#define MTIP_MAX_UNALIGNED_SLOTS       8
+#define MTIP_MAX_UNALIGNED_SLOTS       2

 /* Macro to extract the tag bit number from a tag value. */
 #define MTIP_TAG_BIT(tag)      (tag & 0x1F)
--
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtip32xx: Reduce the number of unaligned writes to 2
  2014-02-18 21:46 [PATCH] mtip32xx: Reduce the number of unaligned writes to 2 Asai Thambi S P
@ 2014-02-18 22:48 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2014-02-18 22:48 UTC (permalink / raw)
  To: Asai Thambi S P; +Cc: linux-kernel, Sam Bradshaw

On Tue, Feb 18 2014, Asai Thambi S P wrote:
> Hi Jens,
> 
> Please include this for 3.14. It is a trivial change, hope it should be ok.

I have applied it. However, your mailer seems to be changing tabs to
spaces, so it had to be hand applied. Not a big deal for this patch, but
worth checking up on for bigger patches.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-18 22:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 21:46 [PATCH] mtip32xx: Reduce the number of unaligned writes to 2 Asai Thambi S P
2014-02-18 22:48 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox