From: Stephen Warren <swarren@wwwdotorg.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linaro-kernel@lists.linaro.org, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
nm@ti.com, kgene.kim@samsung.com, jinchoi@broadcom.com,
tianyu.lan@intel.com, sebastian.capella@linaro.org,
jhbird.choi@samsung.com
Subject: Re: [PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}()
Date: Tue, 18 Feb 2014 15:26:01 -0700 [thread overview]
Message-ID: <5303DDF9.3050806@wwwdotorg.org> (raw)
In-Reply-To: <1455643.Gytp1zkkCW@vostro.rjw.lan>
On 02/18/2014 03:36 PM, Rafael J. Wysocki wrote:
> On Tuesday, February 18, 2014 01:30:52 PM Stephen Warren wrote:
>> On 02/17/2014 02:25 AM, Viresh Kumar wrote:
>>> This patchset creates/calls cpufreq suspend/resume callbacks from dpm_{suspend|resume}()
>>> for handling suspend/resume of cpufreq governors and core.
>>>
>>> There are multiple problems that are fixed by this patch:
>>> - Nishanth Menon (TI) found an interesting problem on his platform, OMAP. His board
>>> wasn't working well with suspend/resume as calls for removing non-boot CPUs
>>> was turning out into a call to drivers ->target() which then tries to play
>>> with regulators. But regulators and their I2C bus were already suspended and
>>> this resulted in a failure. Many platforms have such problems, samsung, tegra,
>>> etc.. They solved it with driver specific PM notifiers where they used to
>>> disable their driver's ->target() routine.
>>> - Lan Tianyu (Intel) & Jinhyuk Choi (Broadcom) found an issue where tunables
>>> configuration for clusters/sockets with non-boot CPUs was getting lost after
>>> suspend/resume, as we were notifying governors with CPUFREQ_GOV_POLICY_EXIT on
>>> removal of the last cpu for that policy and so deallocating memory for
>>> tunables. This is fixed by this patch as we don't allow any operation on
>>> governors after device suspend and before device resume now.
>>
>> The series,
>> Tested-by: Stephen Warren <swarren@nvidia.com>
>
> Is this series necessary to fix bugs that you're seeing in 3.14-rc and if so,
> the what bugs are they?
No, Viresh sent a separate patch that fixed the sysfs warning I was
getting (I believe you've already applied that), and there's still some
ongoing discussion about the other kernel spew.
next prev parent reply other threads:[~2014-02-18 22:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 9:25 [PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() Viresh Kumar
2014-02-17 9:25 ` [PATCH V6 1/7] cpufreq: suspend governors on system suspend/hibernate Viresh Kumar
2014-02-17 9:25 ` [PATCH V6 2/7] cpufreq: suspend governors from dpm_{suspend|resume}() Viresh Kumar
2014-03-02 0:01 ` Rafael J. Wysocki
2014-02-17 9:25 ` [PATCH V6 3/7] cpufreq: call driver's suspend/resume for each policy Viresh Kumar
2014-03-02 0:02 ` Rafael J. Wysocki
2014-02-17 9:25 ` [PATCH V6 4/7] cpufreq: Implement cpufreq_generic_suspend() Viresh Kumar
2014-02-17 9:25 ` [PATCH V6 5/7] cpufreq: exynos: Use cpufreq_generic_suspend() Viresh Kumar
2014-02-17 9:25 ` [PATCH V6 6/7] cpufreq: s5pv210: " Viresh Kumar
2014-02-17 9:25 ` [PATCH V6 7/7] cpufreq: Tegra: " Viresh Kumar
2014-02-18 20:30 ` [PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() Stephen Warren
2014-02-18 22:36 ` Rafael J. Wysocki
2014-02-18 22:26 ` Stephen Warren [this message]
2014-02-18 23:31 ` Rafael J. Wysocki
2014-02-24 6:44 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5303DDF9.3050806@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=cpufreq@vger.kernel.org \
--cc=jhbird.choi@samsung.com \
--cc=jinchoi@broadcom.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sebastian.capella@linaro.org \
--cc=tianyu.lan@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox