From: Milo Kim <milo.kim@ti.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>,
Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 01/10] mfd: Add TI LMU driver
Date: Wed, 19 Feb 2014 08:58:45 +0900 [thread overview]
Message-ID: <5303F3B5.6050806@ti.com> (raw)
In-Reply-To: <20140218082127.GD20218@lee--X1>
Hi Lee,
On 02/18/2014 05:21 PM, Lee Jones wrote:
>>>> + pdata->en_gpio = of_get_named_gpio(node, "ti,enable-gpio", 0);
>>>
>>> There is a global DT property for this already.
>>
>> I've not found it yet, but I agree it looks like general property.
>> So I'll replace "ti,enable-gpio" with "ti,lmu-en-gpio".
>
> Just re-use "gpio-enable". No need for it to be vendor specific.
>
Got it. Thanks!
This GPIO is used for enabling the device. So, "enable-gpio" is more
appropriate name, isn't it?
Best regards,
Milo
next prev parent reply other threads:[~2014-02-18 23:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 6:30 [PATCH 01/10] mfd: Add TI LMU driver Milo Kim
2014-02-17 9:57 ` Lee Jones
2014-02-18 7:45 ` Milo Kim
2014-02-18 8:21 ` Lee Jones
2014-02-18 23:58 ` Milo Kim [this message]
2014-02-19 8:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5303F3B5.6050806@ti.com \
--to=milo.kim@ti.com \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jg1.han@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox