From: John Stultz <john.stultz@linaro.org>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Colin Cross <ccross@android.com>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 14/14] staging: binder: Improve Kconfig entry for ANDROID_BINDER_IPC_32BIT
Date: Tue, 18 Feb 2014 16:30:44 -0800 [thread overview]
Message-ID: <5303FB34.4080306@linaro.org> (raw)
In-Reply-To: <CAMP5Xgfv6mnL8uh_iWCEL7WRtaMEYkE81ehNPtczF-pTAa-ebQ@mail.gmail.com>
On 02/18/2014 04:18 PM, Arve Hjønnevåg wrote:
> On Mon, Feb 17, 2014 at 1:58 PM, John Stultz <john.stultz@linaro.org> wrote:
>> Add a more clear explanation of the option in the prompt, and
>> make the config depend on ANDROID_BINDER_IPC being selected.
>>
>> Also sets the default to y, which matches AOSP.
>>
> I don't know if you want the default to be y. By the time this kernel
> is used, the user-space default may have switched to using the 64 bit
> interface by default. The android-3.10 kernel currently defaulting to
> y since it may get used with a 4.4 android user-space, and because the
> 32 bit arm kernel is missing the 8 byte get_user variant that it
> needs.
My thought is that currently folks who might be using the upstream
kernel would experience less friction, as they are likely to be using
the current userspace. Once the new userspace with the 64bit aware
binder is commonly available, removing the "default y" makes sense.
But until then it seems having a new config that defaults to n and
breaks existing users might be viewed as "unfriendly" :)
Does that seem reasonable?
thanks
-john
prev parent reply other threads:[~2014-02-19 0:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 21:58 [PATCH 00/14][RFC] Android updates for staging-next John Stultz
2014-02-17 21:58 ` [PATCH 01/14] staging: binder: Fix death notifications John Stultz
2014-02-18 19:02 ` Greg KH
2014-02-18 19:21 ` John Stultz
2014-02-18 19:33 ` Greg KH
2014-02-17 21:58 ` [PATCH 02/14] staging: android: Split uapi out of android_alarm.h John Stultz
2014-02-17 21:58 ` [PATCH 03/14] staging: android: Split uapi out of ashmem.h John Stultz
2014-02-17 21:58 ` [PATCH 04/14] staging: android: split uapi out of sync.h and sw_sync.h John Stultz
2014-02-17 21:58 ` [PATCH 05/14] staging: android: Split uapi out of binder.h John Stultz
2014-02-17 21:58 ` [PATCH 06/14] staging: ion: Create separate heap and client debugfs directories John Stultz
2014-02-17 21:58 ` [PATCH 07/14] staging: ion: Fix debugfs handling of multiple kernel clients John Stultz
2014-02-17 21:58 ` [PATCH 08/14] staging: ion: Store a copy of the client name on client creation John Stultz
2014-02-17 21:58 ` [PATCH 09/14] staging: ion: Make sure all clients are exposed in debugfs John Stultz
2014-02-17 21:58 ` [PATCH 10/14] staging: ion: Move shrinker out of heaps John Stultz
2014-02-17 21:58 ` [PATCH 11/14] staging: ion: Add private buffer flag to skip page pooling on free John Stultz
2014-02-17 21:58 ` [PATCH 12/14] staging: binder: Fix ABI for 64bit Android John Stultz
2014-02-18 19:08 ` Greg KH
2014-02-18 19:30 ` John Stultz
2014-02-18 19:49 ` Greg KH
2014-02-18 20:02 ` John Stultz
2014-02-18 20:32 ` Greg KH
2014-02-19 0:08 ` Arve Hjønnevåg
2014-02-19 2:13 ` Greg KH
2014-02-17 21:58 ` [PATCH 13/14] staging: binder: Support concurrent 32 bit and 64 bit processes John Stultz
2014-02-18 19:09 ` Greg KH
2014-02-18 19:10 ` Greg KH
2014-02-18 19:43 ` John Stultz
2014-02-17 21:58 ` [PATCH 14/14] staging: binder: Improve Kconfig entry for ANDROID_BINDER_IPC_32BIT John Stultz
2014-02-19 0:18 ` Arve Hjønnevåg
2014-02-19 0:30 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5303FB34.4080306@linaro.org \
--to=john.stultz@linaro.org \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox