From: Aaron Lu <aaron.lu@intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Takashi Iwai <tiwai@suse.de>,
Igor Gnatenko <i.gnatenko.brain@gmail.com>,
Theodore Tso <tytso@mit.edu>, Peter Weber <bugs@ttyhoney.com>,
Lennart Poettering <lennart@poettering.net>,
Kevin Smith <thirdwiggin@gmail.com>,
Rinat Ibragimov <ibragimovrinat@mail.ru>,
sov.info@mail.ru,
Thomas Christensen <christensenthomas@gmail.com>,
Vladimir Sherenkov <a_12300@mail.ru>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Daniel Vetter <daniel@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v4] ACPI / video: Add systems that should favour native backlight interface
Date: Wed, 19 Feb 2014 10:57:13 +0800 [thread overview]
Message-ID: <53041D89.2050204@intel.com> (raw)
In-Reply-To: <20140218154640.GT5018@intel.com>
On 02/18/2014 11:46 PM, Mika Westerberg wrote:
> On Tue, Feb 18, 2014 at 04:22:27PM +0100, Rafael J. Wysocki wrote:
>> On Tuesday, February 18, 2014 02:31:46 PM Takashi Iwai wrote:
>>> At Tue, 18 Feb 2014 12:34:42 +0200,
>>> Mika Westerberg wrote:
>>>>
>>>> On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote:
>>>>> + {
>>>>> + .callback = video_set_use_native_backlight,
>>>>> + .ident = "HP EliteBook 2013 models",
>>>>> + .matches = {
>>>>> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>>>>> + DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
>>>>> + DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
>>>>> + },
>>>>> + },
>>>>
>>>> I see my device is listed here but the above doesn't really use native
>>>> backlight because it is still in acpi_osi blacklist. Tried this and I can
>>>> see both acpi_video0 and intel_backlight listed under /sys/class/backlight.
>>>> Was this the intention?
>>>
>>> The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I
>>> mentioned earlier. But the revert can be done individually after
>>> merging this patch. Rafael, could you care?
>>
>> Done. Please check the result in linux-pm.git/linux-next.
>
> With your revert and this patch from Aaron, backlight on my HP EliteBook
> Revolve G1 works fine, thanks!
>
> Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks for the test Mika and sorry for all the confusions caused.
-Aaron
next prev parent reply other threads:[~2014-02-19 2:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 5:54 [PATCH v4] ACPI / video: Add systems that should favour native backlight interface Aaron Lu
2014-02-18 10:34 ` Mika Westerberg
2014-02-18 13:31 ` Takashi Iwai
2014-02-18 15:22 ` Rafael J. Wysocki
2014-02-18 15:46 ` Mika Westerberg
2014-02-19 2:57 ` Aaron Lu [this message]
2014-02-18 19:28 ` Igor Gnatenko
2014-02-18 22:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53041D89.2050204@intel.com \
--to=aaron.lu@intel.com \
--cc=a_12300@mail.ru \
--cc=bugs@ttyhoney.com \
--cc=christensenthomas@gmail.com \
--cc=daniel@ffwll.ch \
--cc=i.gnatenko.brain@gmail.com \
--cc=ibragimovrinat@mail.ru \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=lennart@poettering.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sov.info@mail.ru \
--cc=thirdwiggin@gmail.com \
--cc=tiwai@suse.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox