From: Preeti U Murthy <preeti@linux.vnet.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Preeti Murthy <preeti.lkml@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [GIT Pull] timer fixes for 3.14
Date: Wed, 19 Feb 2014 08:53:55 +0530 [thread overview]
Message-ID: <530423CB.5060105@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402181938140.4468@ionos.tec.linutronix.de>
On 02/19/2014 12:10 AM, Thomas Gleixner wrote:
> On Tue, 18 Feb 2014, Preeti Murthy wrote:
>
>> Hi Thomas,
>>
>> With regard to the patch: "tick: Clear broadcast pending bit when
>> switching to oneshot"
>> isn't BROADCAST_EXIT called atleast after initializing the high
>> resolution timers while
>> handling the broadcast IPI and before re-entering idle? This should
>> clear the cpu bit
>> in the pending mask right?
>>
>> idle()
>> |__BROADCAST_ENTER
>> |__halt()
>> |__broadcast_ipi
>> |__init_highres()->clear oneshot mask
>> |__return from interrupt->BROADCAST_EXIT (clear pending mask)
>
> Unfortunately not:
>
> if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_oneshot_mask)) {
> clear pending mask;
> }
>
>> |__re-enter idle
>
> Go figure :)
Ah right! Thanks :)
Regards
Preeti U Murthy
>
> Thanks,
>
> tglx
>
next prev parent reply other threads:[~2014-02-19 3:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 19:21 [GIT Pull] timer fixes for 3.14 Thomas Gleixner
2014-02-18 2:59 ` Preeti Murthy
2014-02-18 18:40 ` Thomas Gleixner
2014-02-19 3:23 ` Preeti U Murthy [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-23 0:02 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530423CB.5060105@linux.vnet.ibm.com \
--to=preeti@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=preeti.lkml@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox