* snd_intel8x0_inside_vm()
@ 2014-02-19 3:48 H. Peter Anvin
2014-02-19 7:09 ` snd_intel8x0_inside_vm() Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: H. Peter Anvin @ 2014-02-19 3:48 UTC (permalink / raw)
To: Konstantin Ozerkov, Denis V. Lunev, Takashi Iwai, Jaroslav Kysela,
Linux Kernel Mailing List, alsa-devel
I just stumbled upon the function snd_intel8x0_inside_vm(), and quite
frankly the code seems bizarre:
/* detect KVM and Parallels virtual environments */
result = kvm_para_available();
#ifdef X86_FEATURE_HYPERVISOR
result = result || boot_cpu_has(X86_FEATURE_HYPERVISOR);
#endif
if (!result)
goto fini;
Why don't we simply rely on the PCI SSIDs?
-hpa
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: snd_intel8x0_inside_vm()
2014-02-19 3:48 snd_intel8x0_inside_vm() H. Peter Anvin
@ 2014-02-19 7:09 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2014-02-19 7:09 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Konstantin Ozerkov, Denis V. Lunev, Jaroslav Kysela,
Linux Kernel Mailing List, alsa-devel
At Tue, 18 Feb 2014 19:48:11 -0800,
H. Peter Anvin wrote:
>
> I just stumbled upon the function snd_intel8x0_inside_vm(), and quite
> frankly the code seems bizarre:
>
> /* detect KVM and Parallels virtual environments */
> result = kvm_para_available();
> #ifdef X86_FEATURE_HYPERVISOR
> result = result || boot_cpu_has(X86_FEATURE_HYPERVISOR);
> #endif
> if (!result)
> goto fini;
>
> Why don't we simply rely on the PCI SSIDs?
The original code checking kvm_para_available() and boot_cpu_has() was
supposed to work for also VirtualBox and VMware. The PCI SSID checks
have been introduced later, and looking at the code again, this might
have broken VirtualBox and VMware workaround. Hmm.
Besides that, the kvm_para_available() and boot_cpu_has() checks are
still left for avoiding unnecessary kernel message (enable/disable VM
workaround) on non-VM kernels.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-19 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-19 3:48 snd_intel8x0_inside_vm() H. Peter Anvin
2014-02-19 7:09 ` snd_intel8x0_inside_vm() Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox