From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751550AbaBSFpc (ORCPT ); Wed, 19 Feb 2014 00:45:32 -0500 Received: from mga01.intel.com ([192.55.52.88]:57265 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbaBSFpa (ORCPT ); Wed, 19 Feb 2014 00:45:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,504,1389772800"; d="scan'208";a="483854618" Message-ID: <530444F7.4060108@linux.intel.com> Date: Wed, 19 Feb 2014 13:45:27 +0800 From: Jiang Liu Organization: Intel User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: "Rafael J . Wysocki" , Lv Zheng , Len Brown , Tony Luck , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC Patch v1 1/6] acpi_pad: simplify notify handler by using acpi_drv_ops->notify References: <1392613271-10912-1-git-send-email-jiang.liu@linux.intel.com> <1392613373-11003-1-git-send-email-jiang.liu@linux.intel.com> <8893595.ITmXn6Kgg5@vostro.rjw.lan> In-Reply-To: <8893595.ITmXn6Kgg5@vostro.rjw.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, Rafael. I will drop this patch then. On 2014/2/18 9:06, Rafael J. Wysocki wrote: > On Monday, February 17, 2014 01:02:48 PM Jiang Liu wrote: >> Use callback acpi_drv_ops->notify to simplify acpi_pad driver's >> notification handling code. >> >> Signed-off-by: Jiang Liu > > There is a plan to move away from using struct acpi_driver objects and > this change will need to be reverted then. I'm not sure if that's really > useful? > >> --- >> drivers/acpi/acpi_pad.c | 25 +++++-------------------- >> 1 file changed, 5 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c >> index df96a0f..1e3ce76 100644 >> --- a/drivers/acpi/acpi_pad.c >> +++ b/drivers/acpi/acpi_pad.c >> @@ -443,14 +443,11 @@ static void acpi_pad_handle_notify(acpi_handle handle) >> mutex_unlock(&isolated_cpus_lock); >> } >> >> -static void acpi_pad_notify(acpi_handle handle, u32 event, >> - void *data) >> +static void acpi_pad_notify(struct acpi_device *device, u32 event) >> { >> - struct acpi_device *device = data; >> - >> switch (event) { >> case ACPI_PROCESSOR_AGGREGATOR_NOTIFY: >> - acpi_pad_handle_notify(handle); >> + acpi_pad_handle_notify(device->handle); >> acpi_bus_generate_netlink_event(device->pnp.device_class, >> dev_name(&device->dev), event, 0); >> break; >> @@ -462,22 +459,10 @@ static void acpi_pad_notify(acpi_handle handle, u32 event, >> >> static int acpi_pad_add(struct acpi_device *device) >> { >> - acpi_status status; >> - >> strcpy(acpi_device_name(device), ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME); >> strcpy(acpi_device_class(device), ACPI_PROCESSOR_AGGREGATOR_CLASS); >> >> - if (acpi_pad_add_sysfs(device)) >> - return -ENODEV; >> - >> - status = acpi_install_notify_handler(device->handle, >> - ACPI_DEVICE_NOTIFY, acpi_pad_notify, device); >> - if (ACPI_FAILURE(status)) { >> - acpi_pad_remove_sysfs(device); >> - return -ENODEV; >> - } >> - >> - return 0; >> + return acpi_pad_add_sysfs(device); >> } >> >> static int acpi_pad_remove(struct acpi_device *device) >> @@ -486,9 +471,8 @@ static int acpi_pad_remove(struct acpi_device *device) >> acpi_pad_idle_cpus(0); >> mutex_unlock(&isolated_cpus_lock); >> >> - acpi_remove_notify_handler(device->handle, >> - ACPI_DEVICE_NOTIFY, acpi_pad_notify); >> acpi_pad_remove_sysfs(device); >> + >> return 0; >> } >> >> @@ -505,6 +489,7 @@ static struct acpi_driver acpi_pad_driver = { >> .ops = { >> .add = acpi_pad_add, >> .remove = acpi_pad_remove, >> + .notify = acpi_pad_notify, >> }, >> }; >> >> >