From: Vladimir Davydov <vdavydov@parallels.com>
To: <Valdis.Kletnieks@vt.edu>
Cc: LKML <linux-kernel@vger.kernel.org>, Jan Kara <jack@suse.cz>,
Wu Fengguang <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Unkillable R-state process stuck in sendfile
Date: Wed, 19 Feb 2014 10:38:18 +0400 [thread overview]
Message-ID: <5304515A.8070809@parallels.com> (raw)
In-Reply-To: <59184.1392750827@turing-police.cc.vt.edu>
On 02/18/2014 11:13 PM, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 17 Feb 2014 16:51:37 +0400, Vladimir Davydov said:
>
>> out_fd = eventfd(0, 0);
>> if (out_fd < 0)
>> err(1, "eventfd");
>> ret = sendfile64(out_fd, in_fd, NULL, SIZE);
>> I'm not sure if this is actually bad and should be fixed, but perhaps
>> it's worth making do_generic_file_read() check for fatal signals pending
>> and break the read loop if so?
> Why do we even allow an eventfd to be fed to sendfile64 at all? What
> does that even *mean*?
I guess it's meaningless, so another fix (if this should be fixed at
all) would be disabling splice to eventfd. However, I cannot be
100%-sure nobody splices data to eventfd...
Thanks.
prev parent reply other threads:[~2014-02-19 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 12:51 Unkillable R-state process stuck in sendfile Vladimir Davydov
2014-02-18 19:13 ` Valdis.Kletnieks
2014-02-19 6:38 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5304515A.8070809@parallels.com \
--to=vdavydov@parallels.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox