Re: ptrace single-stepping change breaks Wine

Kari Hurtta
2005-01-29T09:25:22Z

[ Reading just long long thread (actually from
gmane.comp.emulators.wine.devel) ]

<Pine.LNX.4.58.0412302141320.2280@ppc970.osdl.org>
Linus Torvalds <torvalds@osdl.org>:

> +
> + /*
> + * Was the TF flag set by a debugger? If so, clear it now,
> + * so that register information is correct.
> + */
> + if (tsk->ptrace & PT_DTRACE) {
> + regs->eflags &= ~TF_MASK;
> + tsk->ptrace &= ~PT_DTRACE;
=========================
> + if (!tsk->ptrace & PT_DTRACE)
=======================
> + goto clear_TF;
> + }
> }

Perhaps, I'm stupid.

But is there something strange on that test of tsk->ptrace variable?

Before that PT_DTRACE was cleared from that same tsk->ptrace variable.

/ Kari Hurtta