From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Daeseok Youn <daeseok.youn@gmail.com>, tj@kernel.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static
Date: Wed, 19 Feb 2014 16:38:55 +0400 [thread overview]
Message-ID: <5304A5DF.8070302@cogentembedded.com> (raw)
In-Reply-To: <3035873.ZkIlzycZBr@daeseok-laptop.cloud.net>
Hello.
On 19-0202014 9:07, Daeseok Youn wrote:
> From 2a428e5e45bca3fc38fad17b9e2e14c5e6514ca0 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Wed, 19 Feb 2014 10:56:37 +0900
> Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static
This header is not needed.
> sparse says:
> drivers/ata/libahci.c:1390:5: warning:
> symbol 'ahci_pmp_retry_softreset' was not declared. Should it be static?
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/ata/libahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index 36605ab..f9600fe 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -1387,7 +1387,7 @@ static int ahci_bad_pmp_check_ready(struct ata_link *link)
> return ata_check_ready(status);
> }
>
> -int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class,
> +static int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class,
> unsigned long deadline)
Realign this continuation line too, for it to start under *struct* on the
first line.
WBR, Sergei
next prev parent reply other threads:[~2014-02-19 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 5:07 [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static Daeseok Youn
2014-02-19 12:38 ` Sergei Shtylyov [this message]
2014-02-19 14:14 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5304A5DF.8070302@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=daeseok.youn@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox