From: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
To: Yuan Pengfei <coolypf@qq.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gcov: fix memory allocation problem in gcov_info_dup
Date: Thu, 20 Feb 2014 09:52:25 +0100 [thread overview]
Message-ID: <5305C249.3080502@linux.vnet.ibm.com> (raw)
In-Reply-To: <tencent_791B676E6E166A343D8CB154@qq.com>
On 19.02.2014 11:38, Yuan Pengfei wrote:
> Using -fprofile-values is one case that will cause the memory allocation
> problem. More changes are needed to fully support -fprofile-values. I
> submit this patch first because I think it is obvious and does no harm.
>> I'm unaware of any user of -fprofile-values in the kernel. Are you
>> trying to extend gcov-kernel to also support -fprofile-values? I would
>> expect that additional changes to the .gcda file creation logic are
>> required to fully support this GCC option.
If there is a way to trigger the problem of gcov_info.values == NULL
using the existing gcov-kernel infrastructure then I agree that this
should be fixed. If not, then I would rather see the suggested change as
part of a patch series that enables other profiling types.
--
Peter Oberparleiter
Linux on System z Development - IBM Germany
prev parent reply other threads:[~2014-02-20 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 7:06 [PATCH] gcov: fix memory allocation problem in gcov_info_dup Yuan Pengfei
2014-02-19 8:52 ` Peter Oberparleiter
2014-02-19 10:38 ` Yuan Pengfei
2014-02-20 8:52 ` Peter Oberparleiter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5305C249.3080502@linux.vnet.ibm.com \
--to=oberpar@linux.vnet.ibm.com \
--cc=coolypf@qq.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox