From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752616AbaBTVUU (ORCPT ); Thu, 20 Feb 2014 16:20:20 -0500 Received: from mail-pd0-f175.google.com ([209.85.192.175]:33462 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbaBTVUS (ORCPT ); Thu, 20 Feb 2014 16:20:18 -0500 Message-ID: <5306718E.9080803@linaro.org> Date: Thu, 20 Feb 2014 13:20:14 -0800 From: John Stultz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Thomas Gleixner CC: Alexey Perevalov , linux-kernel@vger.kernel.org, anton@nomsg.org, kyungmin.park@samsung.com, cw00.choi@samsung.com, akpm@linux-foundation.org Subject: Re: [PATCH v3 2/6] hrtimer: Add support for deferrable timer into the hrtimer References: <1392885633-7787-1-git-send-email-a.perevalov@samsung.com> <1392885633-7787-3-git-send-email-a.perevalov@samsung.com> <53064E4A.8030105@linaro.org> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/20/2014 01:18 PM, Thomas Gleixner wrote: > On Thu, 20 Feb 2014, John Stultz wrote: >> On 02/20/2014 12:40 AM, Alexey Perevalov wrote: >>> diff --git a/include/uapi/linux/time.h b/include/uapi/linux/time.h >>> index e75e1b6..bb8dc60 100644 >>> --- a/include/uapi/linux/time.h >>> +++ b/include/uapi/linux/time.h >>> @@ -56,6 +56,9 @@ struct itimerval { >>> #define CLOCK_BOOTTIME_ALARM 9 >>> #define CLOCK_SGI_CYCLE 10 /* Hardware specific */ >>> #define CLOCK_TAI 11 >>> +#define CLOCK_REALTIME_DEFERRABLE 12 >>> +#define CLOCK_MONOTONIC_DEFERRABLE 13 >>> +#define CLOCK_BOOTTIME_DEFERRABLE 14 >> Adding the deferrable HRTIMER bases above is right, but I don't think we >> agreed on adding the _DEFERRABLE clockids. >> >> I'd instead prefer you use add a new TIMER_DEFERABLE flags argument, and >> use the combination of the clockid + flag to decide which HRTIMER base >> is used. > And how does that work with anything else than timerfd? If we add > deferrable posix clocks then we add them for the other interfaces > which take a clockid as well. Other interfaces have flag arguments as well (for things like TIMER_ABSTIME). thanks -john