From: Yijing Wang <wangyijing@huawei.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
David Howells <dhowells@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] frv: replace now removed pci_bus_b() causing build failure
Date: Fri, 21 Feb 2014 09:17:43 +0800 [thread overview]
Message-ID: <5306A937.1040707@huawei.com> (raw)
In-Reply-To: <1392918366-19079-1-git-send-email-paul.gortmaker@windriver.com>
Oh, I'm sorry, Paul,thanks for your patch to correct this.
On 2014/2/21 1:46, Paul Gortmaker wrote:
> In commit 94e6a9b93064b49024b8701d2d81fcb4a821fa09 ("PCI: Remove
> pci_bus_b() and use list_for_each_entry() directly") the function
> pci_bus_b() was removed, but one instance of its usage was missed.
>
> Replace it in the same fashion that the original commit did.
>
> Cc: Yijing Wang <wangyijing@huawei.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [Note: commit ID referenced above is from linux-next and will
> be invalid if the PCI-next content is ever rebased.]
>
> arch/frv/mb93090-mb00/pci-frv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/frv/mb93090-mb00/pci-frv.c b/arch/frv/mb93090-mb00/pci-frv.c
> index c28121765448..67b1d1685759 100644
> --- a/arch/frv/mb93090-mb00/pci-frv.c
> +++ b/arch/frv/mb93090-mb00/pci-frv.c
> @@ -88,7 +88,7 @@ static void __init pcibios_allocate_bus_resources(struct list_head *bus_list)
>
> /* Depth-First Search on bus tree */
> for (ln=bus_list->next; ln != bus_list; ln=ln->next) {
> - bus = pci_bus_b(ln);
> + bus = list_entry(ln, struct pci_bus, node);
> if ((dev = bus->self)) {
> for (idx = PCI_BRIDGE_RESOURCES; idx < PCI_NUM_RESOURCES; idx++) {
> r = &dev->resource[idx];
>
--
Thanks!
Yijing
prev parent reply other threads:[~2014-02-21 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 17:46 [PATCH] frv: replace now removed pci_bus_b() causing build failure Paul Gortmaker
2014-02-20 18:16 ` Bjorn Helgaas
2014-02-21 1:17 ` Yijing Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306A937.1040707@huawei.com \
--to=wangyijing@huawei.com \
--cc=bhelgaas@google.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox