[PATCH] phy: restrict Samsung S5P/Exynos drivers to the respective architectures

[PATCH] phy: restrict Samsung S5P/Exynos drivers to the respective architectures

[Uwe Kleine-König]

Enabling these drivers on platforms not created by Samsung is useless
unless you're doing compile tests. So don't offer the users to enable
them without COMPILE_TEST for configs with S5P/Exynos disabled.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/phy/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index c7a551c2d5f1..82a98f1a5ec2 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -18,6 +18,7 @@ config GENERIC_PHY
 config PHY_EXYNOS_MIPI_VIDEO
 	depends on HAS_IOMEM
 	tristate "S5P/EXYNOS SoC series MIPI CSI-2/DSI PHY driver"
+	depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
 	help
 	  Support for MIPI CSI-2 and MIPI DSI DPHY found on Samsung S5P
 	  and EXYNOS SoCs.
@@ -54,6 +55,7 @@ config TWL4030_USB
 config PHY_EXYNOS_DP_VIDEO
 	tristate "EXYNOS SoC series Display Port PHY driver"
 	depends on OF
+	depends on ARCH_EXYNOS || COMPILE_TEST
 	select GENERIC_PHY
 	help
 	  Support for Display Port PHY found on Samsung EXYNOS SoCs.
-- 
1.8.5.3

Re: [PATCH] phy: restrict Samsung S5P/Exynos drivers to the respective architectures

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

On Fri, Feb 21, 2014 at 03:05:26PM +0100, Uwe Kleine-König wrote:
> Enabling these drivers on platforms not created by Samsung is useless
> unless you're doing compile tests. So don't offer the users to enable
> them without COMPILE_TEST for configs with S5P/Exynos disabled.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

fine by me

Acked-by: Felipe Balbi <balbi@ti.com>

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] phy: restrict Samsung S5P/Exynos drivers to the respective architectures

[Sylwester Nawrocki]

Hi,

On 21/02/14 15:05, Uwe Kleine-König wrote:
> Enabling these drivers on platforms not created by Samsung is useless
> unless you're doing compile tests. So don't offer the users to enable
> them without COMPILE_TEST for configs with S5P/Exynos disabled.

Thanks for the patch, I've already sent something similar to Kishon, but
I've messed up the mailing list address. A bit improved v2 I just posted
can be found here:

https://patchwork.kernel.org/patch/3698271/
https://patchwork.kernel.org/patch/3698251/

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/phy/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index c7a551c2d5f1..82a98f1a5ec2 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -18,6 +18,7 @@ config GENERIC_PHY
>  config PHY_EXYNOS_MIPI_VIDEO
>  	depends on HAS_IOMEM
>  	tristate "S5P/EXYNOS SoC series MIPI CSI-2/DSI PHY driver"
> +	depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
>  	help
>  	  Support for MIPI CSI-2 and MIPI DSI DPHY found on Samsung S5P
>  	  and EXYNOS SoCs.
> @@ -54,6 +55,7 @@ config TWL4030_USB
>  config PHY_EXYNOS_DP_VIDEO
>  	tristate "EXYNOS SoC series Display Port PHY driver"
>  	depends on OF
> +	depends on ARCH_EXYNOS || COMPILE_TEST
>  	select GENERIC_PHY
>  	help
>  	  Support for Display Port PHY found on Samsung EXYNOS SoCs.
> 

Regards,
Sylwester

Re: [PATCH] phy: restrict Samsung S5P/Exynos drivers to the respective architectures

[Uwe Kleine-König]

On Fri, Feb 21, 2014 at 04:55:51PM +0100, Sylwester Nawrocki wrote:
> Hi,
> 
> On 21/02/14 15:05, Uwe Kleine-König wrote:
> > Enabling these drivers on platforms not created by Samsung is useless
> > unless you're doing compile tests. So don't offer the users to enable
> > them without COMPILE_TEST for configs with S5P/Exynos disabled.
> 
> Thanks for the patch, I've already sent something similar to Kishon, but
> I've messed up the mailing list address. A bit improved v2 I just posted
> can be found here:
> 
> https://patchwork.kernel.org/patch/3698271/
> https://patchwork.kernel.org/patch/3698251/
fine for me. If you need to repost feel free to add my Ack for these.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |