From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754517AbaBUVKW (ORCPT ); Fri, 21 Feb 2014 16:10:22 -0500 Received: from terminus.zytor.com ([198.137.202.10]:58927 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbaBUVKV (ORCPT ); Fri, 21 Feb 2014 16:10:21 -0500 Message-ID: <5307C0A0.9010708@zytor.com> Date: Fri, 21 Feb 2014 13:09:52 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Kees Cook , Andrew Morton CC: LKML , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Jianguo Wu , Andy Honig , David Rientjes Subject: Re: [PATCH] x86, kaslr: randomize module base load address References: <20140221202110.GA29885@www.outflux.net> <20140221123658.5752f75eea6506d17bfa313b@linux-foundation.org> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2014 01:05 PM, Kees Cook wrote: > > I've been slapped down for adding more config options in the past, and > I think it's unlikely that people using CONFIG_RANDOMIZE_BASE won't > want the modules base randomized too. I think this is a safe default, > but if you see it as a requirement, I can change it. > No, but I could totally see people wanting to randomize modules but not the main kernel. Why? Because module addresses are already dynamic, so there is no breakage. Whether or not it is *useful* is another matter. -hpa